Issue 2498003: Revert r48735 "Added user image screen for new user login (or old user logging in through"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2498003: Revert r48735 "Added user image screen for new user login (or old user logging in through" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 12 months ago by oshima

Modified:
3 years, 11 months ago

Reviewers:
whywhat, Evan Stade

CC:
chromium-reviews, Paweł Hajdan Jr., Paul Godavari, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Revert r48735 "Added user image screen for new user login (or old user logging in through" This reverts commit 4ffcb495af72106fe243c6982119d799325d86ba. The following tests were failing with this change. NetworkScreenTest.Basic NetworkScreenTest.NetworksConnectedNotSelected NetworkScreenTest.EthernetSelected NetworkScreenTest.WifiSelected NetworkScreenTest.CellularSelected NetworkScreenTest.WifiWaiting LoginScreenTest.TestBasic LoginScreenTest.AuthenticationFailed LoginScreenTest.IncognitoLogin grd files are excluded from revert to avoid build failures. TBR=avayvod@chromium.org BUG=none TEST=chromeos build bot should cycle green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48761

Patch Set 1 #

Patch Set 2 : removed grd files from cl #

Created: 4 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -1143 lines)			Patch
D	chrome/browser/chromeos/login/camera.h	View	1 chunk	+0 lines, -115 lines	0 comments	Download
D	chrome/browser/chromeos/login/camera.cc	View	1 chunk	+0 lines, -410 lines	0 comments	Download
M	chrome/browser/chromeos/login/cookie_fetcher.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View	5 chunks	+3 lines, -30 lines	0 comments	Download
M	chrome/browser/chromeos/login/mock_authenticator.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_observer.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_image_downloader.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
	chrome/browser/chromeos/login/user_image_downloader.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/chromeos/login/user_image_screen.h	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/chromeos/login/user_image_screen.cc	View	1 chunk	+0 lines, -84 lines	0 comments	Download
D	chrome/browser/chromeos/login/user_image_view.h	View	1 chunk	+0 lines, -91 lines	0 comments	Download
D	chrome/browser/chromeos/login/user_image_view.cc	View	1 chunk	+0 lines, -226 lines	0 comments	Download
	chrome/browser/chromeos/login/user_manager.cc	View	3 chunks	+14 lines, -44 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View	5 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	14 chunks	+3 lines, -56 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Trybot results:

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages