Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/bindings/v8/ScriptPromiseResolver.cpp

Issue 24980002: Implement AP2 Promises (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/js/resources/Promise-then-in-workers.js ('k') | Source/bindings/v8/V8HiddenPropertyName.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptPromiseResolver.cpp
diff --git a/Source/bindings/v8/ScriptPromiseResolver.cpp b/Source/bindings/v8/ScriptPromiseResolver.cpp
index 8e2e5b3ed9f1a1a7c824f20e6aa3072797b5483b..bd5ccd84393c6af8bb3f37b20c2ab4e2d36f35cd 100644
--- a/Source/bindings/v8/ScriptPromiseResolver.cpp
+++ b/Source/bindings/v8/ScriptPromiseResolver.cpp
@@ -124,7 +124,7 @@ void ScriptPromiseResolver::resolve(v8::Handle<v8::Value> value)
ASSERT(v8::Context::InContext());
if (!isPending())
return;
- V8PromiseCustom::resolve(m_promise.v8Value().As<v8::Object>(), value, V8PromiseCustom::Asynchronous, m_isolate);
+ V8PromiseCustom::resolve(m_promise.v8Value().As<v8::Object>(), value, m_isolate);
detachPromiseForResolve();
}
@@ -133,7 +133,7 @@ void ScriptPromiseResolver::reject(v8::Handle<v8::Value> value)
ASSERT(v8::Context::InContext());
if (!isPending())
return;
- V8PromiseCustom::reject(m_promise.v8Value().As<v8::Object>(), value, V8PromiseCustom::Asynchronous, m_isolate);
+ V8PromiseCustom::reject(m_promise.v8Value().As<v8::Object>(), value, m_isolate);
detachPromiseForResolve();
}
« no previous file with comments | « LayoutTests/fast/js/resources/Promise-then-in-workers.js ('k') | Source/bindings/v8/V8HiddenPropertyName.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698