Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2154)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp

Issue 2497983002: PaymentApp: Implement PaymentAppManager.setManifest(). (Closed)
Patch Set: PaymentApp: Implement PaymentAppManager.setManifest(). Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp b/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
index 2ca6830c43ec8116ce190fa351b85eaf7e76e27b..d032f50ac49399e039dd4f33aea6bb2eeb770229 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
@@ -90,10 +90,21 @@ void PaymentAppManager::onSetManifest(
payments::mojom::blink::PaymentAppManifestError error) {
DCHECK(resolver);
switch (error) {
+ case payments::mojom::blink::PaymentAppManifestError::NONE:
+ resolver->resolve();
+ break;
case payments::mojom::blink::PaymentAppManifestError::NOT_IMPLEMENTED:
resolver->reject(
DOMException::create(NotSupportedError, "Not implemented yet."));
break;
+ case payments::mojom::blink::PaymentAppManifestError::NO_ACTIVE_WORKER:
+ resolver->reject(
+ DOMException::create(InvalidStateError, "No active service worker."));
+ break;
+ case payments::mojom::blink::PaymentAppManifestError::STORE_MANIFEST_FAILED:
+ resolver->reject(DOMException::create(
+ InvalidStateError, "Storing manifest data is failed."));
+ break;
default:
please use gerrit instead 2016/11/15 20:04:27 If PaymentAppManifestError is an enum, remove the
zino 2016/11/16 18:12:59 Done.
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698