Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2497953002: Drop confusing quotation marks from policy_templates.json (Closed)

Created:
4 years, 1 month ago by bartfab (slow)
Modified:
4 years ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, tnagel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop confusing quotation marks from policy_templates.json Quotation marks should only be used when quoting directly. When paraphrasing, quotation marks are wrong and confuse translators. BUG=664997 TEST=None Committed: https://crrev.com/1184f6a1bcbf0401d1c9f1c0fa430c2d4742c3e3 Cr-Commit-Position: refs/heads/master@{#435246}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/policy/resources/policy_templates.json View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bartfab (slow)
Hi Thiemo, Could you take a quick look?
4 years, 1 month ago (2016-11-14 15:36:33 UTC) #2
Thiemo Nagel
lgtm
4 years, 1 month ago (2016-11-16 16:56:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497953002/1
4 years ago (2016-11-30 12:59:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 14:02:46 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-30 14:04:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1184f6a1bcbf0401d1c9f1c0fa430c2d4742c3e3
Cr-Commit-Position: refs/heads/master@{#435246}

Powered by Google App Engine
This is Rietveld 408576698