Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2497893006: Small fix to passive mixed-content reporting. (Closed)

Created:
4 years, 1 month ago by carlosk
Modified:
4 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small fix to passive mixed-content reporting. There was a change in passive mixed-content reporting behavior when https://crrev.com/2278303002 landed: whereas before this reporting would only occurr if |stricMode| was not true, with that change it would always happen. This change simply reverts to the previous behavior. BUG=631525 Committed: https://crrev.com/51e11a5caf3c825cf7b859948c3cc181a1dcff15 Cr-Commit-Position: refs/heads/master@{#432966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
carlosk
mkwst@: PTAL. More context is provided on my recently added comment to the linked crbug ...
4 years, 1 month ago (2016-11-16 00:06:18 UTC) #4
Mike West
LGTM!
4 years, 1 month ago (2016-11-17 14:23:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497893006/1
4 years, 1 month ago (2016-11-17 19:33:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-17 21:38:04 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 21:40:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51e11a5caf3c825cf7b859948c3cc181a1dcff15
Cr-Commit-Position: refs/heads/master@{#432966}

Powered by Google App Engine
This is Rietveld 408576698