Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2497863002: AbsolutePositioning utilities with tests (Closed)

Created:
4 years, 1 month ago by atotic
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, ikilpatrick, eae
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

AbsolutePositioning utilities with tests These are the routines that implement absolute positioning specification. ComputeAbsoluteHorizontal and ComputeAbsoluteVertical implement the spec. They will be used by block_algorithm to position abspos elements. BUG=635619 Committed: https://crrev.com/5836e40a4c5491a4b7351a8f0835f3a4d36c92d8 Cr-Commit-Position: refs/heads/master@{#433402}

Patch Set 1 #

Total comments: 14

Patch Set 2 : CR fix + %size test #

Patch Set 3 : fix box-sizing, take child writing-mode into account #

Total comments: 3

Patch Set 4 : border-box, and slimmer position #

Patch Set 5 : remove LOG() #

Total comments: 74

Patch Set 6 : CR fixes #

Total comments: 22

Patch Set 7 : CR fixes #

Total comments: 9

Patch Set 8 : CR fixes #

Total comments: 3

Patch Set 9 : Final CR fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+798 lines, -1 line) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h View 1 2 3 4 5 6 1 chunk +66 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc View 1 2 3 4 5 6 7 8 1 chunk +336 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/layout/ng/ng_absolute_utils_test.cc View 1 2 3 4 5 6 1 chunk +392 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_units.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (5 generated)
atotic
ptal. I am using these for abspos positioning, coming up soon.
4 years, 1 month ago (2016-11-14 09:17:41 UTC) #3
ikilpatrick
https://codereview.chromium.org/2497863002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode107 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:107: LayoutUnit border_padding = result.border.left + result.border.right + do we ...
4 years, 1 month ago (2016-11-14 19:23:28 UTC) #4
atotic
comments addressed. I've also added a test for % resolution, which was missing in original ...
4 years, 1 month ago (2016-11-14 20:10:13 UTC) #5
ikilpatrick
https://codereview.chromium.org/2497863002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode107 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:107: LayoutUnit border_padding = result.border.left + result.border.right + On 2016/11/14 ...
4 years, 1 month ago (2016-11-14 20:37:12 UTC) #6
atotic
https://codereview.chromium.org/2497863002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/1/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode107 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:107: LayoutUnit border_padding = result.border.left + result.border.right + On 2016/11/14 ...
4 years, 1 month ago (2016-11-14 21:58:42 UTC) #7
atotic
Fixes for 2 things: ### Take child writing mode into account for estimated width height. ...
4 years, 1 month ago (2016-11-16 00:28:43 UTC) #8
ikilpatrick
https://codereview.chromium.org/2497863002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/40001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode28 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:28: void ComputeAbsoluteHorizontal(const NGConstraintSpace& space, are we able to split ...
4 years, 1 month ago (2016-11-16 23:39:34 UTC) #9
atotic
ptal CR fixes: ComputeVertical/Horizontal now use border-box size NGAbsoluteLogicalPosition only stores size, and insets.
4 years, 1 month ago (2016-11-18 01:22:53 UTC) #10
cbiesinger
lgtm with nits below. We can refine later if necessary. As a general comment, I ...
4 years, 1 month ago (2016-11-18 17:54:20 UTC) #11
atotic
On 2016/11/18 at 17:54:20, cbiesinger wrote: > As a general comment, I am not sure ...
4 years, 1 month ago (2016-11-18 18:18:03 UTC) #12
ikilpatrick
i'd like to have one more pass over this, after comments are fixed if that's ...
4 years, 1 month ago (2016-11-18 20:00:24 UTC) #13
atotic
all CR comments addressed. ptal. https://codereview.chromium.org/2497863002/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode16 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:16: LayoutUnit CustomValueForLength(const Length& length, ...
4 years, 1 month ago (2016-11-18 22:56:10 UTC) #14
ikilpatrick
https://codereview.chromium.org/2497863002/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h (right): https://codereview.chromium.org/2497863002/diff/80001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h#newcode18 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.h:18: struct CORE_EXPORT NGAbsoluteLogicalPosition { On 2016/11/18 22:56:10, atotic2 wrote: ...
4 years, 1 month ago (2016-11-18 23:58:28 UTC) #15
atotic
done. ptal https://codereview.chromium.org/2497863002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/100001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode93 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:93: // Compute margins On 2016/11/18 at 23:58:28, ...
4 years, 1 month ago (2016-11-19 00:19:58 UTC) #16
cbiesinger
https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode22 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:22: DCHECK(!length.isPercent() || max_value != NGSizeIndefinite); isPercentOrCalc https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode62 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:62: // ...
4 years, 1 month ago (2016-11-19 00:30:29 UTC) #17
atotic
CR fixes done, ptal https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode22 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:22: DCHECK(!length.isPercent() || max_value != NGSizeIndefinite); ...
4 years, 1 month ago (2016-11-19 00:37:01 UTC) #18
ikilpatrick
lgtm, thanks! https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/120001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode101 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:101: // Margins are negative. make same as ...
4 years, 1 month ago (2016-11-19 00:37:40 UTC) #19
cbiesinger
lgtm https://codereview.chromium.org/2497863002/diff/140001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/140001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode18 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:18: LayoutUnit max_value, I forgot to answer that question, ...
4 years, 1 month ago (2016-11-19 00:51:09 UTC) #20
atotic
https://codereview.chromium.org/2497863002/diff/140001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right): https://codereview.chromium.org/2497863002/diff/140001/third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc#newcode62 third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:62: // TODO(atotic): This should useResolve{Inline,Block}Length On 2016/11/19 at 00:51:09, ...
4 years, 1 month ago (2016-11-19 02:55:18 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497863002/160001
4 years, 1 month ago (2016-11-19 02:55:51 UTC) #24
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 1 month ago (2016-11-19 04:36:44 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 04:39:23 UTC) #27
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/5836e40a4c5491a4b7351a8f0835f3a4d36c92d8
Cr-Commit-Position: refs/heads/master@{#433402}

Powered by Google App Engine
This is Rietveld 408576698