Create TemplateUrlData to base::Dictionary utility functions

components/search_engines/template_url_data.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_
 #define COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "components/search_engines/template_url_id.h"
 #include "url/gurl.h"
 
+namespace base {
+class ListValue;
+}
+
 // The data for the TemplateURL.  Separating this into its own class allows most
 // users to do SSA-style usage of TemplateURL: construct a TemplateURLData with
 // whatever fields are desired, then create an immutable TemplateURL from it.
 struct TemplateURLData {
   TemplateURLData();
   TemplateURLData(const TemplateURLData& other);
+  // Creates a TemplateURLData suitable for prepopulated engines.
+  // Note that unlike in the default constructor, |safe_for_autoreplace| will
+  // be set to true. date_created and last_modified will be set to null time
+  // value, instead of current time.
+  TemplateURLData(const base::string16& name,
+                  const base::string16& keyword,
+                  const base::StringPiece& search_url,

[Peter Kasting, 2016/11/21 21:03:54]

Prefer to pass StringPiece by value (see
https://cs.chromium.org/chromium/src/base/strings/string_piece.h?rcl=0&l=14 ).

Obviously, if we are able to switch to something that passes these as
std::string, this becomes moot.  If not, consider adding a comment about why
these are StringPieces and not strings.

+                  const base::StringPiece& suggest_url,
+                  const base::StringPiece& instant_url,
+                  const base::StringPiece& image_url,
+                  const base::StringPiece& new_tab_url,
+                  const base::StringPiece& contextual_search_url,
+                  const base::StringPiece& search_url_post_params,
+                  const base::StringPiece& suggest_url_post_params,
+                  const base::StringPiece& instant_url_post_params,
+                  const base::StringPiece& image_url_post_params,
+                  const base::StringPiece& favicon_url,
+                  const base::StringPiece& encoding,
+                  const base::ListValue& alternate_urls_list,
+                  const base::StringPiece& search_terms_replacement_key,
+                  int prepopulate_id);
+
   ~TemplateURLData();
 
   // A short description of the template. This is the name we show to the user
   // in various places that use TemplateURLs. For example, the location bar
   // shows this when the user selects a substituting match.
   void SetShortName(const base::string16& short_name);
   const base::string16& short_name() const { return short_name_; }
 
   // The shortcut for this TemplateURL.  |keyword| must be non-empty.
   void SetKeyword(const base::string16& keyword);
@@ skipping 78 matching lines @@
 
  private:
   // Private so we can enforce using the setters and thus enforce that these
   // fields are never empty.
   base::string16 short_name_;
   base::string16 keyword_;
   std::string url_;
 };
 
 #endif  // COMPONENTS_SEARCH_ENGINES_TEMPLATE_URL_DATA_H_