Chromium Code Reviews
DescriptionRevert of Ensure clean up functions of MessageFilter are paired with their initialization functions (patchset #3 id:40001 of https://codereview.chromium.org/2488753002/ )
Reason for revert:
This causes crashes on SyncMessageFilter::OnFilterAdded.
BUG=664511
Original issue's description:
> Ensure clean up functions of MessageFilter are paired with their initialization functions
>
> This is an attempt to address http://crrev.com/2469123003/#msg28.
> MessageFilter::OnFilterRemoved and OnChannelClosing are now called even
> when the channel is closed before it completes its initialization.
> In that case, these functions are not paired to OnFilterAdded and
> OnChannelOpened.
>
> This CL makes OnFilterAdded and OnChannelConnected right before pending
> filters are removed, so that they are paired with their clean up functions.
>
> BUG=
>
> Committed: https://crrev.com/8941d772a304208a5ad4fb47dfa3c669fb3b5d11
> Cr-Commit-Position: refs/heads/master@{#431199}
TBR=rockot@chromium.org,boliu@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
Committed: https://crrev.com/389a8b2996d01fa8ee4059cb5614434029af9380
Cr-Commit-Position: refs/heads/master@{#431842}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||