Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 2497843002: Revert of Ensure clean up functions of MessageFilter are paired with their initialization functions (Closed)

Created:
4 years, 1 month ago by tzik
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ensure clean up functions of MessageFilter are paired with their initialization functions (patchset #3 id:40001 of https://codereview.chromium.org/2488753002/ ) Reason for revert: This causes crashes on SyncMessageFilter::OnFilterAdded. BUG=664511 Original issue's description: > Ensure clean up functions of MessageFilter are paired with their initialization functions > > This is an attempt to address http://crrev.com/2469123003/#msg28. > MessageFilter::OnFilterRemoved and OnChannelClosing are now called even > when the channel is closed before it completes its initialization. > In that case, these functions are not paired to OnFilterAdded and > OnChannelOpened. > > This CL makes OnFilterAdded and OnChannelConnected right before pending > filters are removed, so that they are paired with their clean up functions. > > BUG= > > Committed: https://crrev.com/8941d772a304208a5ad4fb47dfa3c669fb3b5d11 > Cr-Commit-Position: refs/heads/master@{#431199} TBR=rockot@chromium.org,boliu@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/389a8b2996d01fa8ee4059cb5614434029af9380 Cr-Commit-Position: refs/heads/master@{#431842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ipc/ipc_channel_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tzik
Created Revert of Ensure clean up functions of MessageFilter are paired with their initialization functions
4 years, 1 month ago (2016-11-14 07:32:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497843002/1
4 years, 1 month ago (2016-11-14 07:33:02 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 08:35:57 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 08:38:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/389a8b2996d01fa8ee4059cb5614434029af9380
Cr-Commit-Position: refs/heads/master@{#431842}

Powered by Google App Engine
This is Rietveld 408576698