Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2497743002:
[MD settings] make whole cookie visible (Closed)
|
Created:
4 years, 1 month ago by dschuyler Modified:
4 years, 1 month ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] make whole cookie visible
This CL wraps long cookie data in the cookie details page so that the
whole cookie value can be seen. It also makes the cookie details
selectable (to allow a copy to paste the text elsewhere).
BUG=663725
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/07ebd1af7c0ab751773de5b6f8b226dd082ab291
Cr-Commit-Position: refs/heads/master@{#431733}
Patch Set 1 #
Total comments: 3
Messages
Total messages: 16 (9 generated)
Description was changed from ========== [MD settings] make whole cookie visible This CL wraps long cookie data in the cookie details page so that the whole cookie value can be seen. It also makes the cookie details selectable (to allow a copy to paste the text elsewhere). BUG=663625 ========== to ========== [MD settings] make whole cookie visible This CL wraps long cookie data in the cookie details page so that the whole cookie value can be seen. It also makes the cookie details selectable (to allow a copy to paste the text elsewhere). BUG=663625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
dschuyler@chromium.org changed reviewers: + dpapad@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2497743002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_data_details_subpage.html (right): https://codereview.chromium.org/2497743002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_data_details_subpage.html:19: -webkit-user-select: text; user-select should work I think (no prefix needed). Also, is site_data_details_subpage.html only used for cookies? Or are we accidentally making more things selectable than just cookies?
https://codereview.chromium.org/2497743002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_data_details_subpage.html (right): https://codereview.chromium.org/2497743002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_data_details_subpage.html:19: -webkit-user-select: text; On 2016/11/12 01:15:14, dpapad wrote: > user-select should work I think (no prefix needed). > > Also, is site_data_details_subpage.html only used for cookies? Or are we > accidentally making more things selectable than just cookies? It's only cookies.
lgtm https://codereview.chromium.org/2497743002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/site_settings/site_data_details_subpage.html (right): https://codereview.chromium.org/2497743002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/site_settings/site_data_details_subpage.html:19: -webkit-user-select: text; On 2016/11/12 at 01:26:47, dschuyler wrote: > On 2016/11/12 01:15:14, dpapad wrote: > > user-select should work I think (no prefix needed). As of https://bugs.chromium.org/p/chromium/issues/detail?id=461018, -webkit-user-select is just an alias for user-select. We can cleanup our Settings code in a separate CL. > > > > Also, is site_data_details_subpage.html only used for cookies? Or are we > > accidentally making more things selectable than just cookies? > > It's only cookies. Ok.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] make whole cookie visible This CL wraps long cookie data in the cookie details page so that the whole cookie value can be seen. It also makes the cookie details selectable (to allow a copy to paste the text elsewhere). BUG=663625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] make whole cookie visible This CL wraps long cookie data in the cookie details page so that the whole cookie value can be seen. It also makes the cookie details selectable (to allow a copy to paste the text elsewhere). BUG=663625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/07ebd1af7c0ab751773de5b6f8b226dd082ab291 Cr-Commit-Position: refs/heads/master@{#431733} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/07ebd1af7c0ab751773de5b6f8b226dd082ab291 Cr-Commit-Position: refs/heads/master@{#431733}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] make whole cookie visible This CL wraps long cookie data in the cookie details page so that the whole cookie value can be seen. It also makes the cookie details selectable (to allow a copy to paste the text elsewhere). BUG=663625 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/07ebd1af7c0ab751773de5b6f8b226dd082ab291 Cr-Commit-Position: refs/heads/master@{#431733} ========== to ========== [MD settings] make whole cookie visible This CL wraps long cookie data in the cookie details page so that the whole cookie value can be seen. It also makes the cookie details selectable (to allow a copy to paste the text elsewhere). BUG=663725 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/07ebd1af7c0ab751773de5b6f8b226dd082ab291 Cr-Commit-Position: refs/heads/master@{#431733} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
