Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 2497723002: Show the tutorial during OOBE (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show the tutorial during OOBE BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/fd046d62bd6bc1aed90edc479d198684fb707dda Cr-Commit-Position: refs/heads/master@{#431804}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
David Tseng
4 years, 1 month ago (2016-11-11 23:40:07 UTC) #3
dmazzoni
lgtm
4 years, 1 month ago (2016-11-11 23:48:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497723002/1
4 years, 1 month ago (2016-11-12 00:14:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/313738)
4 years, 1 month ago (2016-11-12 01:05:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497723002/20001
4 years, 1 month ago (2016-11-13 07:45:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-13 08:50:49 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fd046d62bd6bc1aed90edc479d198684fb707dda Cr-Commit-Position: refs/heads/master@{#431804}
4 years, 1 month ago (2016-11-13 08:52:29 UTC) #14
hiroshige
4 years, 1 month ago (2016-11-14 04:58:27 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2498903002/ by hiroshige@chromium.org.

The reason for reverting is: Suspected to cause interactive_ui_tests failures on
ChromeOS.

BUG=664881
.

Powered by Google App Engine
This is Rietveld 408576698