Rehash canonical constants table for each class that can be affected by the 'become' operation

Rehash canonical constants table for each class that can be affected by the 'become' operation

Fixes #27803

Rehashing all classes canonical constant's takes 3milliseconds for gallery on an Nexus 7.

BUG=
R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/2e197df37d7772d2b501c5e35d3698adbbae8c7f

[Cutch, 2016-11-14 17:43:30]

johnmccutchan@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[rmacnak, 2016-11-15 18:52:44]

lgtm

[Cutch, 2016-11-15 22:39:33]

Description was changed from

==========
Rehash canonical constants table for each class that can be affected by the
'become' operation

Fixes #27803

BUG=
==========

to

==========
Rehash canonical constants table for each class that can be affected by the
'become' operation

Fixes #27803

Rehashing all classes canonical constant's takes 3milliseconds for gallery on an
Nexus 7.

BUG=
==========

[siva, 2016-11-15 22:58:22]

lgtm

https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.cc
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:1177: for (intptr_t cid = kInstanceCid; cid < top;
cid++) {
Should this be (kNumPredefinedCids + 1)

https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:1178: if (!class_table->IsValidIndex(cid) ||
!class_table->HasValidClassAt(cid)) {
IsValidIndex(cid) is implicit right with the check above,

maybe just

ASSERT(class_table->IsValidIndex(cid));

https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:1185: }
By running from kNumPredefinedCids this check for number and string woul
not be needed.

[rmacnak, 2016-11-15 23:13:33]

https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.cc
File runtime/vm/isolate_reload.cc (right):

https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.c...
runtime/vm/isolate_reload.cc:1177: for (intptr_t cid = kInstanceCid; cid < top;
cid++) {
On 2016/11/15 22:58:22, siva wrote:
> Should this be (kNumPredefinedCids + 1)

No, we still need to rehash array, growable array, map, etc.

[Cutch, 2016-11-15 23:27:12]

On 2016/11/15 23:13:33, rmacnak wrote:
> https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.cc
> File runtime/vm/isolate_reload.cc (right):
> 
>
https://codereview.chromium.org/2497673004/diff/1/runtime/vm/isolate_reload.c...
> runtime/vm/isolate_reload.cc:1177: for (intptr_t cid = kInstanceCid; cid <
top;
> cid++) {
> On 2016/11/15 22:58:22, siva wrote:
> > Should this be (kNumPredefinedCids + 1)
> 
> No, we still need to rehash array, growable array, map, etc.

Yes, Ryan is correct. When I originally wrote this CL I used kNumPredefinedCids
but that doesn't fix the issue because it skips classes we need to
recanonoicalize.

[Cutch, 2016-11-17 15:41:29]

Description was changed from

==========
Rehash canonical constants table for each class that can be affected by the
'become' operation

Fixes #27803

Rehashing all classes canonical constant's takes 3milliseconds for gallery on an
Nexus 7.

BUG=
==========

to

==========
Rehash canonical constants table for each class that can be affected by the
'become' operation

Fixes #27803

Rehashing all classes canonical constant's takes 3milliseconds for gallery on an
Nexus 7.

BUG=
R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2e197df37d7772d2b501c5e35d3698adbbae8c7f
==========

[Cutch, 2016-11-17 15:41:31]

Committed patchset #1 (id:1) manually as
2e197df37d7772d2b501c5e35d3698adbbae8c7f (presubmit successful).