Add WebsiteSettings strings for malware/UwS/phishing

Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629, 657231
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).

Committed: https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666
Cr-Commit-Position: refs/heads/master@{#431818}

[estark, 2016-11-11 22:21:02]

Description was changed from

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

BUG=646629
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

to

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

[estark, 2016-11-11 22:22:14]

estark@chromium.org changed reviewers:
+ lgarron@chromium.org, raymes@chromium.org

[estark, 2016-11-11 22:22:15]

raymes, lgarron, PTAL, thanks!

https://codereview.chromium.org/2497673002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2497673002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:491:
&site_identity_details_);
I don't 100% understand what's going on here with site_identity_details_. It
looks to me like it's used on android to set the description, but not on other
platforms.

[lgarron, 2016-11-11 22:39:01]

LGTM; about as good as this CL can be until we refactor WebsiteSettings.

https://codereview.chromium.org/2497673002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/2497673002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:362: -      <message
name="IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT" desc="Text that is displayed in the
header of the Website Settings popup if the website uses secure transport.">
Thanks; could you add 657231 to BUGS=?

https://codereview.chromium.org/2497673002/diff/1/chrome/browser/ui/website_s...
File chrome/browser/ui/website_settings/website_settings.cc (right):

https://codereview.chromium.org/2497673002/diff/1/chrome/browser/ui/website_s...
chrome/browser/ui/website_settings/website_settings.cc:491:
&site_identity_details_);
On 2016/11/11 at 22:22:15, estark (slow thru Nov 18) wrote:
> I don't 100% understand what's going on here with site_identity_details_. It
looks to me like it's used on android to set the description, but not on other
platforms.

Yeah, the identity/connection split is legacy code for desktop code, but I'm not
planning to remove it until Q1 because it's still used on Android.

Assuming you meant for Safe Browsing errors to show up over invalid certs (which
sounds fine), this looks alright to me.

[estark, 2016-11-11 22:52:36]

Description was changed from

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

to

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629,657231
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

[estark, 2016-11-11 23:55:49]

https://codereview.chromium.org/2497673002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (left):

https://codereview.chromium.org/2497673002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:362: -      <message
name="IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT" desc="Text that is displayed in the
header of the Website Settings popup if the website uses secure transport.">
On 2016/11/11 22:39:01, lgarron wrote:
> Thanks; could you add 657231 to BUGS=?

Done.

[raymes, 2016-11-14 01:27:39]

lgtm

[estark, 2016-11-14 01:29:35]

Thanks, both!

[estark, 2016-11-14 01:29:40]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-11-14 01:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 02:17:59]

Description was changed from

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629,657231
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

to

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629,657231
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

[commit-bot: I haz the power, 2016-11-14 02:17:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-14 02:20:59]

Description was changed from

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629,657231
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).
==========

to

==========
Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG=646629,657231
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).

Committed: https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666
Cr-Commit-Position: refs/heads/master@{#431818}
==========

[commit-bot: I haz the power, 2016-11-14 02:21:00]

Patchset 1 (id:??) landed as
https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666
Cr-Commit-Position: refs/heads/master@{#431818}