Move use_brlapi build flag to chrome.

Move use_brlapi build flag to chrome.

It used to be in the global build faetures file but is only used by Chrome.

The define is removed. It was only used in one place to make sure the compile
matched the build flags, which in this case is uselessly circular.

Committed: https://crrev.com/519b7b6003aab8cd70808bb07f5d289e10149367
Cr-Commit-Position: refs/heads/master@{#431665}

[brettw, 2016-11-11 19:27:39]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[brettw, 2016-11-11 19:27:39]

https://codereview.chromium.org/2497653002/diff/1/build/linux/BUILD.gn
File build/linux/BUILD.gn (left):

https://codereview.chromium.org/2497653002/diff/1/build/linux/BUILD.gn#oldcode10
build/linux/BUILD.gn:10: deps = [
I think the effect of this is to make libbrlapi be a dependency of
freetype2?!?!? In any case, I don't think we need this at all.

[brettw, 2016-11-11 19:27:43]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-11 19:28:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 20:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-11 20:36:32]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-11-11 22:07:31]

lgtm

https://codereview.chromium.org/2497653002/diff/1/build/linux/BUILD.gn
File build/linux/BUILD.gn (left):

https://codereview.chromium.org/2497653002/diff/1/build/linux/BUILD.gn#oldcode10
build/linux/BUILD.gn:10: deps = [
On 2016/11/11 19:27:39, brettw (ping on IM after 24h) wrote:
> I think the effect of this is to make libbrlapi be a dependency of
> freetype2?!?!? In any case, I don't think we need this at all.

Yes, there doesn't seem like any way this can be right ...

[brettw, 2016-11-11 22:09:19]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-11 22:09:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 22:15:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-11 22:22:40]

Description was changed from

==========
Move use_brlapi build flag to chrome.

It used to be in the global build faetures file but is only used by Chrome.

The define is removed. It was only used in one place to make sure the compile
matched the build flags, which in this case is uselessly circular.
==========

to

==========
Move use_brlapi build flag to chrome.

It used to be in the global build faetures file but is only used by Chrome.

The define is removed. It was only used in one place to make sure the compile
matched the build flags, which in this case is uselessly circular.

Committed: https://crrev.com/519b7b6003aab8cd70808bb07f5d289e10149367
Cr-Commit-Position: refs/heads/master@{#431665}
==========

[commit-bot: I haz the power, 2016-11-11 22:22:41]

Patchset 1 (id:??) landed as
https://crrev.com/519b7b6003aab8cd70808bb07f5d289e10149367
Cr-Commit-Position: refs/heads/master@{#431665}