Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2497633002: Move PaintResult enum out of PaintLayerPainter.h into PaintResult.h (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
wkorman
CC:
chromium-reviews, blink-reviews, dshwang, blink-reviews-paint_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PaintResult enum out of PaintLayerPainter.h into PaintResult.h This is split from https://codereview.chromium.org/2430313004/. BUG=663208 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/6886d425973ff6e47cc02b6eaf0144ffbee3475e Cr-Commit-Position: refs/heads/master@{#431649}

Patch Set 1 #

Patch Set 2 : Correct base #

Patch Set 3 : Adjust includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -28 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.h View 2 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 7 chunks +7 lines, -10 lines 0 comments Download
A third_party/WebKit/Source/core/paint/PaintResult.h View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Xianzhu
4 years, 1 month ago (2016-11-11 18:11:26 UTC) #3
wkorman
lgtm
4 years, 1 month ago (2016-11-11 19:31:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497633002/40001
4 years, 1 month ago (2016-11-11 19:34:58 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-11 21:29:04 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 21:45:01 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6886d425973ff6e47cc02b6eaf0144ffbee3475e
Cr-Commit-Position: refs/heads/master@{#431649}

Powered by Google App Engine
This is Rietveld 408576698