Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Unified Diff: media/test/pipeline_integration_test.cc

Issue 2497603003: Roll src/third_party/ffmpeg/ 3c7a09882..cdf4accee (3188 commits). (Closed)
Patch Set: Updated DEPS to ffmpeg origin/master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/ffmpeg_h265_to_annex_b_bitstream_converter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/test/pipeline_integration_test.cc
diff --git a/media/test/pipeline_integration_test.cc b/media/test/pipeline_integration_test.cc
index acba6677d45afb3391b13be5eef8931baa0bc80d..d2493ed5cd9dc794e20338c3e2903b074eccb335 100644
--- a/media/test/pipeline_integration_test.cc
+++ b/media/test/pipeline_integration_test.cc
@@ -184,17 +184,6 @@ static base::Time kLiveTimelineOffset() {
return timeline_offset;
}
-// FFmpeg only supports time a resolution of seconds so this
-// helper function truncates a base::Time to seconds resolution.
-static base::Time TruncateToFFmpegTimeResolution(base::Time t) {
- base::Time::Exploded exploded_time;
- t.UTCExplode(&exploded_time);
- exploded_time.millisecond = 0;
- base::Time out_time;
- EXPECT_TRUE(base::Time::FromUTCExploded(exploded_time, &out_time));
- return out_time;
-}
-
// Note: Tests using this class only exercise the DecryptingDemuxerStream path.
// They do not exercise the Decrypting{Audio|Video}Decoder path.
class FakeEncryptedMedia {
@@ -1178,11 +1167,7 @@ TEST_F(PipelineIntegrationTest, BasicPlaybackLive) {
EXPECT_HASH_EQ("f0be120a90a811506777c99a2cdf7cc1", GetVideoHash());
EXPECT_HASH_EQ("-3.59,-2.06,-0.43,2.15,0.77,-0.95,", GetAudioHash());
-
- // TODO: Fix FFmpeg code to return higher resolution time values so
- // we don't have to truncate our expectations here.
- EXPECT_EQ(TruncateToFFmpegTimeResolution(kLiveTimelineOffset()),
- demuxer_->GetTimelineOffset());
+ EXPECT_EQ(kLiveTimelineOffset(), demuxer_->GetTimelineOffset());
}
TEST_F(PipelineIntegrationTest, S32PlaybackHashed) {
« no previous file with comments | « media/filters/ffmpeg_h265_to_annex_b_bitstream_converter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698