Limit memory usage for sqlite3 fuzzer + move it to sqlite dir.

Limit memory usage for sqlite3 fuzzer + move it to sqlite dir.

R=aizatsky@chromium.org, kcc@chromium.org, ochang@chromium.org, shess@chromium.org
BUG=657486
Committed: https://crrev.com/947d0b893e2af8923bb86eb3e849e25d4dff710d
Cr-Commit-Position: refs/heads/master@{#431589}

[mmoroz, 2016-11-11 15:24:05]

https://codereview.chromium.org/2497603002/diff/1/third_party/sqlite/BUILD.gn
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/2497603002/diff/1/third_party/sqlite/BUILD.gn...
third_party/sqlite/BUILD.gn:133: if (use_libfuzzer) {
That's wrong, we have another flag which should work for more cases (e.g.
use_afl). I'll update this line.

[Scott Hess - ex-Googler, 2016-11-11 15:41:32]

lgtm

[Scott Hess - ex-Googler, 2016-11-11 15:43:09]

https://codereview.chromium.org/2497603002/diff/1/third_party/sqlite/BUILD.gn
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/2497603002/diff/1/third_party/sqlite/BUILD.gn...
third_party/sqlite/BUILD.gn:133: if (use_libfuzzer) {
On 2016/11/11 15:24:05, mmoroz wrote:
> That's wrong, we have another flag which should work for more cases (e.g.
> use_afl). I'll update this line.

WRT my LGTM, consider it sticky WRT the other code, because I'm not in a
position to consider whether you're using the right gn flag :-).  But using that
to limit the lengths seems reasonable.

[mmoroz, 2016-11-11 16:14:41]

On 2016/11/11 15:43:09, Scott Hess wrote:
> https://codereview.chromium.org/2497603002/diff/1/third_party/sqlite/BUILD.gn
> File third_party/sqlite/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2497603002/diff/1/third_party/sqlite/BUILD.gn...
> third_party/sqlite/BUILD.gn:133: if (use_libfuzzer) {
> On 2016/11/11 15:24:05, mmoroz wrote:
> > That's wrong, we have another flag which should work for more cases (e.g.
> > use_afl). I'll update this line.
> 
> WRT my LGTM, consider it sticky WRT the other code, because I'm not in a
> position to consider whether you're using the right gn flag :-).  But using
that
> to limit the lengths seems reasonable.

Thanks for clarification. I believe that I'm doing that right, but will wait for
someone of other reviewers to confirm :)

[inferno, 2016-11-11 16:41:23]

inferno@chromium.org changed reviewers:
+ inferno@chromium.org

[inferno, 2016-11-11 16:41:23]

lgtm with nits.

https://codereview.chromium.org/2497603002/diff/20001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/2497603002/diff/20001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:134: # Limit max length of data blobs and queries
for fuzzing builds by 128M.
s/max/maximum
s/128M/128Mb

https://codereview.chromium.org/2497603002/diff/20001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:276: dict =
"//testing/libfuzzer/fuzzers/dicts/generated/sqlite3_prepare_v2_fuzzer.dict"
If we are moving the fuzzer next to code, we should move the dict too.

[mmoroz, 2016-11-11 16:44:47]

https://codereview.chromium.org/2497603002/diff/20001/third_party/sqlite/BUIL...
File third_party/sqlite/BUILD.gn (right):

https://codereview.chromium.org/2497603002/diff/20001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:134: # Limit max length of data blobs and queries
for fuzzing builds by 128M.
On 2016/11/11 16:41:23, inferno wrote:
> s/max/maximum
> s/128M/128Mb

Done.

https://codereview.chromium.org/2497603002/diff/20001/third_party/sqlite/BUIL...
third_party/sqlite/BUILD.gn:276: dict =
"//testing/libfuzzer/fuzzers/dicts/generated/sqlite3_prepare_v2_fuzzer.dict"
On 2016/11/11 16:41:23, inferno wrote:
> If we are moving the fuzzer next to code, we should move the dict too.

Done.

[mmoroz, 2016-11-11 16:45:09]

The CQ bit was checked by mmoroz@chromium.org

[mmoroz, 2016-11-11 16:45:09]

The patchset sent to the CQ was uploaded after l-g-t-m from shess@chromium.org,
inferno@chromium.org
Link to the patchset: https://codereview.chromium.org/2497603002/#ps40001
(title: "Fix nits.")

[commit-bot: I haz the power, 2016-11-11 16:45:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 17:46:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-11 17:57:30]

Description was changed from

==========
Limit memory usage for sqlite3 fuzzer + move it to sqlite dir.

R=aizatsky@chromium.org, kcc@chromium.org, ochang@chromium.org,
shess@chromium.org
BUG=657486
==========

to

==========
Limit memory usage for sqlite3 fuzzer + move it to sqlite dir.

R=aizatsky@chromium.org, kcc@chromium.org, ochang@chromium.org,
shess@chromium.org
BUG=657486

Committed: https://crrev.com/947d0b893e2af8923bb86eb3e849e25d4dff710d
Cr-Commit-Position: refs/heads/master@{#431589}
==========

[commit-bot: I haz the power, 2016-11-11 17:57:31]

Patchset 3 (id:??) landed as
https://crrev.com/947d0b893e2af8923bb86eb3e849e25d4dff710d
Cr-Commit-Position: refs/heads/master@{#431589}