Source/core/loader/HistoryController.cpp - Issue 24976002: HistoryController shouldn't call confusingAndOftenMisusedAttached

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/HistoryController.cpp

Issue 24976002: HistoryController shouldn't call confusingAndOftenMisusedAttached (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use the new hotness Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/HistoryController.cpp

diff --git a/Source/core/loader/HistoryController.cpp b/Source/core/loader/HistoryController.cpp

index f6d2cec7ca5ac9b565de504e2e11d680d146dfb5..e687f6545e9d2b781584921026f3398265a4827a 100644

--- a/Source/core/loader/HistoryController.cpp

+++ b/Source/core/loader/HistoryController.cpp

@@ -123,7 +123,7 @@ void HistoryController::saveDocumentAndScrollState()

Document* document = m_frame->document();

ASSERT(document);

- if (m_currentItem->isCurrentDocument(document) && document->confusingAndOftenMisusedAttached()) {

+ if (m_currentItem->isCurrentDocument(document) && document->isActive()) {

abarth-chromium 2013/09/30 05:06:29 I updated this CL to use the new hotness.

LOG(Loading, "WebCoreLoading %s: saving form state to %p", m_frame->tree()->uniqueName().string().utf8().data(), m_currentItem.get());

m_currentItem->setDocumentState(document->formElementsState());

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »