Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2497573003: Reland: [compiler] Fix flipped boolean checks in marked tier-up (Closed)

Created:
4 years, 1 month ago by Leszek Swirski
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: [compiler] Fix flipped boolean checks in marked tier-up Fixes incorrect checks for handle validity when checking the compiled code, as well as incorrect uses of tst in arm and ppc flag checking code. Also adds a test that the tier-up works correctly. Reland of https://codereview.chromium.org/2448933002 BUG=v8:5512 Committed: https://crrev.com/f6701a8cbd382abb5146b4bf8fa997367b8b1a53 Cr-Commit-Position: refs/heads/master@{#40930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -5 lines) Patch
M src/builtins/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +5 lines, -0 lines 0 comments Download
A test/mjsunit/shared-function-tier-up-default.js View 1 chunk +32 lines, -0 lines 0 comments Download
A test/mjsunit/shared-function-tier-up-ignition.js View 1 chunk +41 lines, -0 lines 0 comments Download
A test/mjsunit/shared-function-tier-up-turbo.js View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Leszek Swirski
machenbach@chromium.org: Please review changes in mjsunit.status rmcilroy@chromium.org: Please "review" everything else, with the knowledge that ...
4 years, 1 month ago (2016-11-11 13:11:37 UTC) #4
Michael Achenbach
lgtm
4 years, 1 month ago (2016-11-11 13:53:26 UTC) #8
rmcilroy
LGTM
4 years, 1 month ago (2016-11-11 13:57:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497573003/1
4 years, 1 month ago (2016-11-11 14:11:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 14:16:24 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:30:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f6701a8cbd382abb5146b4bf8fa997367b8b1a53
Cr-Commit-Position: refs/heads/master@{#40930}

Powered by Google App Engine
This is Rietveld 408576698