Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2497543003: ContentSecurityPolicy: avoid defining static String singletons. (Closed)

Created:
4 years, 1 month ago by sof
Modified:
4 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ContentSecurityPolicy: avoid defining static String singletons. As CSP is used by multiple threads, we cannot define string literals in terms of DEFINE_STATIC_LOCAL(). Follow what is done elsewhere for ContentSecurityPolicy and resort to using plain string literals. R= BUG= Committed: https://crrev.com/6824a5fe98ea6501513973db94700085b6b71f22 Cr-Commit-Position: refs/heads/master@{#431956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look. Noticed that http/tests/fetch/referrer/origin-when-cross-origin-serviceworker-from-document.html was flakily failing, e.g., https://storage.googleapis.com/chromium-layout-test-archives/linux_chromium_rel_ng/335665/layout-test-results/http/tests/fetch/referrer/origin-when-cross-origin-serviceworker-from-document-crash-log.txt
4 years, 1 month ago (2016-11-11 15:48:44 UTC) #4
Mike West
LGTM, thanks!
4 years, 1 month ago (2016-11-14 14:01:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497543003/1
4 years, 1 month ago (2016-11-14 18:39:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:16:55 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:22:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6824a5fe98ea6501513973db94700085b6b71f22
Cr-Commit-Position: refs/heads/master@{#431956}

Powered by Google App Engine
This is Rietveld 408576698