[promises] Move promise constructor to TFS

src/builtins/builtins.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_H_
 #define V8_BUILTINS_BUILTINS_H_
 
 #include "src/base/flags.h"
 #include "src/handles.h"
 
@@ skipping 545 matching lines @@
   CPP(ObjectPrototypeSetProto)                                                \
   CPP(ObjectSeal)                                                             \
   CPP(ObjectValues)                                                           \
                                                                               \
   TFS(HasProperty, BUILTIN, kNoExtraICState, HasProperty)                     \
   TFS(InstanceOf, BUILTIN, kNoExtraICState, Compare)                          \
   TFS(OrdinaryHasInstance, BUILTIN, kNoExtraICState, Compare)                 \
   TFS(ForInFilter, BUILTIN, kNoExtraICState, ForInFilter)                     \
                                                                               \
   /* Promise */                                                               \
+  TFJ(PromiseConstructor, 1)                                                  \
+  TFJ(PromiseInternalConstructor, 0)                                          \
+  TFJ(IsPromise, 1)                                                           \

[caitp, 2016/11/29 13:33:00]

Maybe for the internal functions, we should skip the arguments adaptor frame by
using SharedFunctionInfo::kDontAdaptArgumentsSentinel as the arg count, and just
add a CSA_SLOW_ASSERT() to ensure it's the right count in debug builds

[gsathya, 2016/12/01 20:03:53]

AFAIK, this sets up the number of stack parameters which needs to be 1 here. The
adaptor frame creation is determined by
SharedFunctionInfo::internal_formal_parameter_count (which is set to
kDontAdaptArgumentsSentinel in the bootstrapper for this function).

[caitp, 2016/12/01 20:12:37]

well, what's going on with StringFromCharCode then? I don't know, wasn't CC'd on
that bug when that change landed. I'd have to take a closer look to see what
this really does.

   CPP(CreateResolvingFunctions)                                               \
   CPP(PromiseResolveClosure)                                                  \
   CPP(PromiseRejectClosure)                                                   \
                                                                               \
   /* Proxy */                                                                 \
   CPP(ProxyConstructor)                                                       \
   CPP(ProxyConstructor_ConstructStub)                                         \
                                                                               \
   /* Reflect */                                                               \
   ASM(ReflectApply)                                                           \
@@ skipping 265 matching lines @@
 
   friend class Isolate;
 
   DISALLOW_COPY_AND_ASSIGN(Builtins);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_H_