[promises] Move promise constructor to TFS

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 3565 matching lines @@
     Handle<String> key = factory()->Promise_string();
     Handle<JSFunction> function = Handle<JSFunction>::cast(
         JSReceiver::GetProperty(global_object, key).ToHandleChecked());
     JSFunction::EnsureHasInitialMap(function);
     function->initial_map()->set_instance_type(JS_PROMISE_TYPE);
     function->shared()->SetConstructStub(
         *isolate()->builtins()->JSBuiltinsConstructStub());
     InstallWithIntrinsicDefaultProto(isolate(), function,
                                      Context::PROMISE_FUNCTION_INDEX);
 
+    // TODO(gsathya): Fix up the wiring to be the correct Promise constructor.
+    Handle<JSObject> prototype =
+        factory()->NewJSObject(isolate()->object_function(), TENURED);
+    Handle<JSFunction> promise2_fun = SimpleInstallFunction(
+        global_object, "Promise2", Builtins::kPromiseConstructor, 1, false);

[Benedikt Meurer, 2016/11/11 06:50:30]

You cannot say "dont adapt" arguments here, but have the builtin expect exactly
one parameter. That will crash with some stack corruption if you pass less or
more than one parameter.

[gsathya, 2016/11/22 04:31:43]

Done.

+
+    Handle<SharedFunctionInfo> shared(promise2_fun->shared(), isolate());
+    shared->SetConstructStub(*isolate()->builtins()->PromiseConstructor());

[Benedikt Meurer, 2016/11/11 06:50:30]

I'm not sure we currently support having a TFS builtin as construct stub. I
suppose we need some smallish ASM wrapper stub around this, which tail calls
into the real PromiseConstructor code.

[gsathya, 2016/11/22 04:31:43]

Done.

+    shared->set_instance_class_name(isolate()->heap()->Promise_string());
+    shared->DontAdaptArguments();

[Benedikt Meurer, 2016/11/11 06:50:30]

This is reundant (and wrong).

[gsathya, 2016/11/22 04:31:43]

Done.

+
     {
       Handle<Code> code = handle(
           isolate()->builtins()->builtin(Builtins::kPromiseResolveClosure),
           isolate());
       Handle<SharedFunctionInfo> info =
           isolate()->factory()->NewSharedFunctionInfo(factory()->empty_string(),
                                                       code, false);
       info->set_internal_formal_parameter_count(1);
       info->set_length(1);
       native_context()->set_promise_resolve_shared_fun(*info);
@@ skipping 956 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8