Add retries to file operations for Windows.

Add retries to file operations for Windows.

BUG=chromium:663990
TEST=None
R=hinoka@chromium.org, nodir@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/4625b5adb8bd2bb5767ab4bccc59fc51284066a6

[nodir, 2016-11-11 01:34:30]

lgtm

https://codereview.chromium.org/2497503002/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/2497503002/diff/1/git_cache.py#newcode247
git_cache.py:247: self.print('Error moving [%s] to [%s] (%d / %d): %s' % (
attempt %d / %d
so make it obviously clear

https://codereview.chromium.org/2497503002/diff/1/git_cache.py#newcode248
git_cache.py:248: src, dst, i+1, count, str(e)))
sleep?

https://codereview.chromium.org/2497503002/diff/1/git_cache.py#newcode248
git_cache.py:248: src, dst, i+1, count, str(e)))
str unnecessary?

https://codereview.chromium.org/2497503002/diff/1/git_cache.py#newcode344
git_cache.py:344: gclient_utils.rm_file_or_tree(tempdir)
can you please add a retry here too?

[nodir, 2016-11-11 01:53:59]

https://codereview.chromium.org/2497503002/diff/40001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/2497503002/diff/40001/git_cache.py#newcode234
git_cache.py:234: sleep_time = 1
Strange indentation

https://codereview.chromium.org/2497503002/diff/40001/git_cache.py#newcode247
git_cache.py:247: src, dst, count, str(e)))
str unnecessary?

https://codereview.chromium.org/2497503002/diff/40001/git_cache.py#newcode347
git_cache.py:347: gclient_utils.rm_file_or_tree(tempdir)
Retry here please

[dnj, 2016-11-11 02:01:25]

PTAL, added a retry there and in one other place. Common retry function.

[dnj, 2016-11-11 02:03:02]

Patchset #5 (id:80001) has been deleted

[nodir, 2016-11-11 02:10:23]

lgtm

https://codereview.chromium.org/2497503002/diff/100001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/2497503002/diff/100001/git_cache.py#newcode70
git_cache.py:70: except excs as e:
python dynamicity is crazy

https://codereview.chromium.org/2497503002/diff/100001/git_cache.py#newcode74
git_cache.py:74: printerr('Retrying %s in %d seconds (%d / %d attempts): %s' % (
%.2f seconds

[nodir, 2016-11-11 02:10:56]

Description was changed from

==========
Add retries to rename for Windows.

BUG=chromium:663990
TEST=None
R=hinoka@chromium.org, nodir@chromium.org
==========

to

==========
Add retries to file operations for Windows.

BUG=chromium:663990
TEST=None
R=hinoka@chromium.org, nodir@chromium.org
==========

[dnj, 2016-11-11 02:16:45]

https://codereview.chromium.org/2497503002/diff/100001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/2497503002/diff/100001/git_cache.py#newcode70
git_cache.py:70: except excs as e:
On 2016/11/11 02:10:22, nodir wrote:
> python dynamicity is crazy

Acknowledged.

https://codereview.chromium.org/2497503002/diff/100001/git_cache.py#newcode74
git_cache.py:74: printerr('Retrying %s in %d seconds (%d / %d attempts): %s' % (
On 2016/11/11 02:10:22, nodir wrote:
> %.2f seconds

Done.

[dnj, 2016-11-11 02:17:07]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-11-11 02:17:08]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2497503002/#ps30002
(title: "Better formatting string.")

[nodir, 2016-11-11 02:17:10]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-11-11 02:17:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 02:23:28]

Description was changed from

==========
Add retries to file operations for Windows.

BUG=chromium:663990
TEST=None
R=hinoka@chromium.org, nodir@chromium.org
==========

to

==========
Add retries to file operations for Windows.

BUG=chromium:663990
TEST=None
R=hinoka@chromium.org, nodir@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/4625b5adb8bd2b...
==========

[commit-bot: I haz the power, 2016-11-11 02:23:29]

Committed patchset #6 (id:30002) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/4625b5adb8bd2b...