- Implement a first cut for const String.env in the VM to allow

sdk/lib/core/string.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * A sequence of characters.
  *
  * A string can be either single or multiline. Single line strings are
@@ skipping 107 matching lines @@
    *
    * Creating a String with half of a surrogate pair is legal but generally
    * discouraged.
    */
   factory String.fromCharCode(int charCode) {
     List<int> charCodes = new List<int>.filled(1, charCode);
     return new String.fromCharCodes(charCodes);
   }
 
   /**
+   * Returns the string for the given environment variable [name] or

[Ivan Posva, 2013/09/27 07:21:01]

Maybe it should say "for the given configuration variable"?

[kasperl, 2013/09/27 07:32:43]

Nit: I don't think we should limit ourselves to environment variables. Also I'd
prefer a non-abbreviated name for this.

Ideally, the variables you can refer to can be defined by the embedder so we can
have them put in script tags in Dartium or passed on the command line for the
standalone VM and dart2js.

[Ivan Posva, 2013/09/27 21:05:06]

That is why had the remark about changing the comment. What we need to decide is
what we call this feature. When I initially wrote this patch in March, the plan
was to call this configuration. Any suggestions as far as naming goes are
appreciated.

I'll continue with env until we settled on a better plan. The other suggestion
the reviews namely "fromEnvironment" is also too specific.

+   * [defaultValue] if [name] is not present.
+   */
+  external const String.env(String name, String defaultValue);

[bakster, 2013/09/27 07:44:39]

How about adding a default value to defaultValue?
  external const String.env(String name, [String defaultValue=''] );

[Ivan Posva, 2013/09/27 21:05:06]

I was thinking the same thing, but instead I would leave the defaults null,
allowing the program to figure out whether a value had been specified or not:

external const String.env(String name, {String default = null});

+
+  /**
    * Gets the character (as a single-code-unit [String]) at the given [index].
    *
    * The returned string represents exactly one UTF-16 code unit, which may be
    * half of a surrogate pair. A single member of a surrogate pair is an
    * invalid UTF-16 string:
    *
    *     var clef = '\u{1D11E}';
    *     // These represent invalid UTF-16 strings.
    *     clef[0].codeUnits;      // [0xD834]
    *     clef[1].codeUnits;      // [0xDD1E]
@@ skipping 511 matching lines @@
         _position = position - 1;
         _currentCodePoint = _combineSurrogatePair(prevCodeUnit, codeUnit);
         return true;
       }
     }
     _position = position;
     _currentCodePoint = codeUnit;
     return true;
   }
 }