- Implement a first cut for const String.env in the VM to allow

sdk/lib/core/int.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.core;
 
 /**
  * An arbitrarily large integer.
  *
  * **Note:** When compiling to JavaScript, integers are
@@ skipping 234 matching lines @@
    * sign, the [onError] is called with the [source] as argument, and its return
    * value is used instead. If no [onError] is provided, a [FormatException]
    * is thrown.
    *
    * The [onError] function is only invoked if [source] is a [String]. It is
    * not invoked if the [source] is, for example, `null`.
    */
   external static int parse(String source,
                             { int radix,
                               int onError(String source) });
+
+  /**

[bakster, 2013/09/27 07:44:39]

Too long lines.

[Ivan Posva, 2013/09/27 21:05:06]

Thanks for noticing. Comments will need to be updated to match the naming in any
case.

+   * Returns the integer value for the given environment variable [name] or [defaultValue]
+   * if [name] is not present. If the value of the environment variable is not a valid
+   * integer literal a [FormatException] is thrown.

[Lasse Reichstein Nielsen, 2013/09/28 00:13:38]

Consider reformatting as:

  The integer value of the environment value for the key `name`.
  
  If [name] is not an environment key, instead returns [defaultValue].

  Throws a [FormatException] if the environment value is not an
  integer literal.

I try to avoid "returns" since it is a constructor, but that is what it does
with [defaultValue]. That suggests that it is an odd kind of constructor - more
like a factory constructor. Maybe mark it as such, if it has to be a constructor
at all. 

+   */
+  external int.env(String name, int defaultValue);

[Lasse Reichstein Nielsen, 2013/09/28 00:13:38]

Why is this a constructor instead of a static function?

I seem to remember the idea was to make it a const constructor (so the  value
would be a const value), but in that case, it can't throw.

 }