Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2497493005: Reordering MediaSessionAction seek backward/forward (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin (slow to review), dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, mlamouri+watch-blink_chromium.org, qsr+mojo_chromium.org, Srirama, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reordering MediaSessionAction seek backward/forward The current order of MediaSessionAction is a bit odd since we have "next track" after "previous track", while "seek backward" after "seek forward". i.e. "|<" ">|" and ">>" "<<". Reordering seek backward/forward will make it more natural. BUG=656563 Committed: https://crrev.com/d24d2f35eebdcfb9629ffe4641c65b833a1d3135 Cr-Commit-Position: refs/heads/master@{#433251}

Patch Set 1 #

Patch Set 2 : rebased #

Messages

Total messages: 27 (19 generated)
Zhiqiang Zhang (Slow)
PTAL Found the current action order is really awkward. The spec will be fixed in ...
4 years, 1 month ago (2016-11-14 16:12:34 UTC) #9
mlamouri (slow - plz ping)
lgtm
4 years, 1 month ago (2016-11-18 14:20:51 UTC) #10
mlamouri (slow - plz ping)
Don't forget to add a BUG or BUG=None ;)
4 years, 1 month ago (2016-11-18 14:21:13 UTC) #11
Zhiqiang Zhang (Slow)
+tsepez to rubberstamp media_session.mojom
4 years, 1 month ago (2016-11-18 14:49:00 UTC) #15
Tom Sepez
RS LGTM
4 years, 1 month ago (2016-11-18 17:17:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497493005/40001
4 years, 1 month ago (2016-11-18 18:34:59 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-18 18:43:55 UTC) #25
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:46:46 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d24d2f35eebdcfb9629ffe4641c65b833a1d3135
Cr-Commit-Position: refs/heads/master@{#433251}

Powered by Google App Engine
This is Rietveld 408576698