Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2497453002: Use title case for verbose "Not Secure" omnibox state on Mac. (Closed)

Created:
4 years, 1 month ago by lgarron
Modified:
4 years, 1 month ago
Reviewers:
emilyschechter
CC:
chromium-reviews, estark
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use title case for verbose "Not Secure" omnibox state on Mac. BUG=664141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M components/omnibox_strings.grdp View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
lgarron
emilyschechter@, could you review?
4 years, 1 month ago (2016-11-10 21:44:24 UTC) #2
emilyschechter
lgtm
4 years, 1 month ago (2016-11-13 18:01:35 UTC) #7
emilyschechter
4 years, 1 month ago (2016-11-13 18:03:55 UTC) #8
Message was sent while issue was closed. 
On 2016/11/13 18:01:35, emilyschechter wrote:
> lgtm

LGTM (for conceptually assigning the description to both "Not secure" and "Not
Secure").
Please note that I can't actually review syntax, i.e. I don't know if
use_titlecase should actually correspond to "secure" or "Secure".

Powered by Google App Engine
This is Rietveld 408576698