Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2497413002: Remove logic forcing paint invalidation with non-composited scrollbars (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove logic forcing paint invalidation with non-composited scrollbars The logic has been unnecessary since we had PaintInvalidationCapableScrollableArea which invalidates old and new visual rects of scrollbars. This can reduce paint invalidation differences between RLS and non-RLS about LayoutViews. BUG=660195 TEST=paint/invalidation/resize-scrollable-div.html TEST=paint/invalidation/scrollbar-invalidation-on-resize.html TEST=paint/invalidation/scrollbar-invalidation-on-resize-with-border.html CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/bf9526786aab6e8317e015249f88cca8b44cac35 Cr-Commit-Position: refs/heads/master@{#431927}

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
Xianzhu
4 years, 1 month ago (2016-11-14 20:22:44 UTC) #5
chrishtr
lgtm
4 years, 1 month ago (2016-11-14 21:39:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497413002/1
4 years, 1 month ago (2016-11-14 22:07:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 22:44:33 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 22:58:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf9526786aab6e8317e015249f88cca8b44cac35
Cr-Commit-Position: refs/heads/master@{#431927}

Powered by Google App Engine
This is Rietveld 408576698