Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times quickly

Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
Committed: https://crrev.com/e299953842a5913ea92cfeb6f0079acfb22ea407
Cr-Commit-Position: refs/heads/master@{#432352}

[pkotwicz, 2016-11-14 19:38:10]

Description was changed from

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK. The problem is with
TabContentManager::CacheTab(). If TabContentManager::CacheTab() is called while
a readback for the tab is pending, ThumbnailCache::Remove() is called.
ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

to

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK. The problem is with
TabContentManager::CacheTab(). If TabContentManager::CacheTab() is called while
a readback for the tab is pending, ThumbnailCache::Remove() is called.
ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

[pkotwicz, 2016-11-14 19:38:10]

pkotwicz@chromium.org changed reviewers:
+ dtrainor@chromium.org

[pkotwicz, 2016-11-14 19:39:07]

Description was changed from

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK. The problem is with
TabContentManager::CacheTab(). If TabContentManager::CacheTab() is called while
a readback for the tab is pending, ThumbnailCache::Remove() is called.
ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

to

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

[pkotwicz, 2016-11-14 19:41:36]

dtrainor@ can you please take a look?

[David Trainor- moved to gerrit, 2016-11-15 20:09:19]

lgtm thanks for the fix!

[pkotwicz, 2016-11-15 20:53:11]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:53:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 21:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 21:12:26]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[pkotwicz, 2016-11-16 01:33:55]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-11-16 01:34:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 01:54:11]

Description was changed from

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

to

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

[commit-bot: I haz the power, 2016-11-16 01:54:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-16 01:57:17]

Description was changed from

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096
==========

to

==========
Fix DCHECK failure when ChromeActivity#onPauseWithNative() is called many times
quickly

ChromeActivity#onPauseWithNative() is called several as a result of calling
WebappDelegateFactory#activateContents() for a WebAPK.

The problem is with TabContentManager::CacheTab(). If
TabContentManager::CacheTab() is called while a readback for the tab is
pending, ThumbnailCache::Remove() is called.

ThumbnailCache::Remove() removes the entry for |tab_id| from
|ThumbnailCache::thumbnail_meta_data_|. When the readback completes, the
callback (TabContentManager::PutThumbnailIntoCache()) fails because
|ThumbnailCache::thumbnail_meta_data_| does not contain an entry for |tab_id|.

BUG=665096

Committed: https://crrev.com/e299953842a5913ea92cfeb6f0079acfb22ea407
Cr-Commit-Position: refs/heads/master@{#432352}
==========

[commit-bot: I haz the power, 2016-11-16 01:57:19]

Patchset 1 (id:??) landed as
https://crrev.com/e299953842a5913ea92cfeb6f0079acfb22ea407
Cr-Commit-Position: refs/heads/master@{#432352}