Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3434)

Unified Diff: chrome/browser/ui/views/frame/browser_view.h

Issue 2497373003: Add tab status to accessibility labels (Closed)
Patch Set: Fix unit tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h
index d9e2f42902a8a5f813bb4731ff1c0489a30aaf29..aec944bdc40af2b8e1960b04c34896b641ad65be 100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -32,6 +32,7 @@
#include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
#include "chrome/browser/ui/views/frame/web_contents_close_handler.h"
#include "chrome/browser/ui/views/load_complete_listener.h"
+#include "chrome/browser/ui/views/tabs/tab_renderer_data.h"
#include "chrome/common/features.h"
#include "components/omnibox/browser/omnibox_popup_model_observer.h"
#include "ui/base/accelerators/accelerator.h"
@@ -471,6 +472,11 @@ class BrowserView : public BrowserWindow,
views::WebView* GetContentsWebViewForTest() { return contents_web_view_; }
views::WebView* GetDevToolsWebViewForTest() { return devtools_web_view_; }
+ // Creates an accessible tab label for screen readers that includes the tab
sky 2016/12/12 17:25:09 Please move this above testing interface functions
edwardjung 2016/12/12 19:16:20 Done.
+ // status. This takes the form of "Page title - Tab state".
+ base::string16 GetAccessibleTabLabel(bool include_app_name,
+ TabRendererData data) const;
sky 2016/12/12 17:25:08 const TabRendererData&
edwardjung 2016/12/12 19:16:20 Done.
+
private:
// Do not friend BrowserViewLayout. Use the BrowserViewLayoutDelegate
// interface to keep these two classes decoupled and testable.

Powered by Google App Engine
This is Rietveld 408576698