chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc - Issue 2497373003: Add tab status to accessibility labels

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc

Issue 2497373003: Add tab status to accessibility labels (Closed)

Patch Set: Fix unit tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/views/frame/browser_view.cc ('K') | « chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | chrome/browser/ui/views/tabs/tab_controller.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h"	5 #include "chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h"

6	6

7 #include "chrome/browser/ui/views/tabs/tab_renderer_data.h"	7 #include "chrome/browser/ui/views/tabs/tab_renderer_data.h"

8 #include "chrome/browser/ui/views/tabs/tab_strip.h"	8 #include "chrome/browser/ui/views/tabs/tab_strip.h"

9	9

10 FakeBaseTabStripController::FakeBaseTabStripController()	10 FakeBaseTabStripController::FakeBaseTabStripController()

(...skipping 130 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
141 void FakeBaseTabStripController::OnStoppedDraggingTabs() {	141 void FakeBaseTabStripController::OnStoppedDraggingTabs() {

142 }	142 }

143	143

144 void FakeBaseTabStripController::CheckFileSupported(const GURL& url) {	144 void FakeBaseTabStripController::CheckFileSupported(const GURL& url) {

145 tab_strip_->FileSupported(url, true);	145 tab_strip_->FileSupported(url, true);

146 }	146 }

147	147

148 SkColor FakeBaseTabStripController::GetToolbarTopSeparatorColor() const {	148 SkColor FakeBaseTabStripController::GetToolbarTopSeparatorColor() const {

149 return SK_ColorBLACK;	149 return SK_ColorBLACK;

150 }	150 }

	151

	152 base::string16 FakeBaseTabStripController::GetAccessibleTabName() const {

	153 base::string16 title;

	154 return title;
	dmazzoni 2016/12/12 18:26:01 Just return base::string16(); Just return base::string16(); edwardjung 2016/12/12 19:16:20 Done. Show quoted text On 2016/12/12 18:26:01, dmazzoni wrote: > Just return base::string16(); Done.
	155 }

OLD	NEW