Add tab status to accessibility labels

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 1576 matching lines @@
                             activate_modal_dialog_factory_.GetWeakPtr()));
 #endif
   return false;
 }
 
 base::string16 BrowserView::GetWindowTitle() const {
   return browser_->GetWindowTitleForCurrentTab(true /* include_app_name */);
 }
 
 base::string16 BrowserView::GetAccessibleWindowTitle() const {
-  const bool include_app_name = false;
-  if (IsIncognito()) {
-    return l10n_util::GetStringFUTF16(
-        IDS_ACCESSIBLE_INCOGNITO_WINDOW_TITLE_FORMAT,
-        browser_->GetWindowTitleForCurrentTab(include_app_name));
-  }
-  return browser_->GetWindowTitleForCurrentTab(include_app_name);

[sky, 2016/11/26 17:19:33]

GetWindowTitleForCurrentTab() has a couple of heuristics for getting the title
that you're missing. I would prefer GetAccessibleTabLabel is here, and not the
in the tab class, mostly because I think you want parts of what
GetWindowTitleForCurrentTab does.

[edwardjung, 2016/12/06 20:23:16]

Done.

+  Tab* current_tab =
+      tabstrip_->tab_at(browser_->tab_strip_model()->active_index());
+  return current_tab->GetAccessibleTabLabel();
 }
 
 views::View* BrowserView::GetInitiallyFocusedView() {
   return nullptr;
 }
 
 bool BrowserView::ShouldShowWindowTitle() const {
 #if defined(USE_ASH)
   // For Ash only, trusted windows (apps and settings) do not show a title,
   // crbug.com/119411. Child windows (i.e. popups) do show a title.
@@ skipping 982 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }