Add tab status to accessibility labels

chrome/browser/ui/views/tabs/tab.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/tab.h"
 
 #include <stddef.h>
 #include <limits>
 #include <utility>
 
@@ skipping 295 matching lines @@
                 1.5 * scale);
   path.rLineTo(0, 1);
   path.close();
 
   if (unscale_at_end && (scale != 1))
     path.transform(SkMatrix::MakeScale(1.f / scale));
 
   return path;
 }
 
+// Creates an accessible tab label for screen readers describing the tab status.
+base::string16 GetAccessibleTabLabel(const TabRendererData& data) {
+  base::string16 tab_label = data.title;
+
+  VLOG(1) << "Tabcontents Error:" << data.network_state << "\n";
+  VLOG(1) << "Tabcontents incognito:" << data.incognito << "\n";
+
+  if (data.network_state == TabRendererData::NETWORK_STATE_ERROR) {
+    tab_label.append(l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_NETWORK_ERROR));

[dmazzoni, 2016/11/14 21:59:02]

Maybe need whitesapce between the existing tab title and the extra label?

Or maybe a hyphen, like the Chrome main window title?

"Google Hangouts - Audio Playing"

[edwardjung, 2016/11/24 11:36:43]

Switched to hyphen. Also on the advice of lpalmaro@, 'incognito' is appended in
addition to any other tab states. 

+  } else if (data.incognito) {
+    //  Incognito tab
+    tab_label.append(l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_INCOGNITO));
+  } else {
+    // Alert tab states.
+    switch (data.alert_state) {
+      case TabAlertState::AUDIO_PLAYING:
+        tab_label.append(
+            l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_AUDIO_PLAYING));
+        break;
+      case TabAlertState::USB_CONNECTED:
+        tab_label.append(
+            l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_USB_CONNECTED));
+        break;
+      case TabAlertState::BLUETOOTH_CONNECTED:
+        tab_label.append(
+            l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_BLUETOOTH_CONNECTED));
+        break;
+      case TabAlertState::MEDIA_RECORDING:
+        tab_label.append(
+            l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_MEDIA_RECORDING));
+        break;
+      case TabAlertState::AUDIO_MUTING:
+        tab_label.append(
+            l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_AUDIO_MUTING));
+        break;
+      case TabAlertState::TAB_CAPTURING:
+        tab_label.append(
+            l10n_util::GetStringUTF16(IDS_TAB_AX_LABEL_TAB_CAPTURING));
+        break;
+      default:
+        break;
+    }
+  }
+  return tab_label;
+}
+
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // FaviconCrashAnimation
 //
 //  A custom animation subclass to manage the favicon crash animation.
 class Tab::FaviconCrashAnimation : public gfx::LinearAnimation,
                                    public gfx::AnimationDelegate {
  public:
   explicit FaviconCrashAnimation(Tab* target)
@@ skipping 161 matching lines @@
   loading_start_time_ = base::TimeTicks();
   waiting_state_ = gfx::ThrobberWaitingState();
 }
 
 bool Tab::ThrobberView::CanProcessEventsWithinSubtree() const {
   return false;
 }
 
 void Tab::ThrobberView::OnPaint(gfx::Canvas* canvas) {
   const TabRendererData::NetworkState state = owner_->data().network_state;
-  if (state == TabRendererData::NETWORK_STATE_NONE)
+  if (state == TabRendererData::NETWORK_STATE_NONE ||
+      state == TabRendererData::NETWORK_STATE_ERROR)
     return;
 
   const ui::ThemeProvider* tp = GetThemeProvider();
   const gfx::Rect bounds = GetLocalBounds();
   if (state == TabRendererData::NETWORK_STATE_WAITING) {
     if (waiting_start_time_ == base::TimeTicks())
       waiting_start_time_ = base::TimeTicks::Now();
 
     waiting_state_.elapsed_time = base::TimeTicks::Now() - waiting_start_time_;
     gfx::PaintThrobberWaiting(
@@ skipping 159 matching lines @@
     showing_pinned_tab_title_changed_indicator_ = false;
 
   DataChanged(old);
 
   Layout();
   SchedulePaint();
 }
 
 void Tab::UpdateLoadingAnimation(TabRendererData::NetworkState state) {
   if (state == data_.network_state &&
-      state == TabRendererData::NETWORK_STATE_NONE) {
-    // If the network state is none and hasn't changed, do nothing. Otherwise we
-    // need to advance the animation frame.
+      (state == TabRendererData::NETWORK_STATE_NONE ||
+      state == TabRendererData::NETWORK_STATE_ERROR)) {
+    // If the network state is none or is a network error and hasn't changed,
+    // do nothing. Otherwise we need to advance the animation frame.
     return;
   }
 
   data_.network_state = state;
   AdvanceLoadingAnimation();
 }
 
 void Tab::StartPulse() {
   pulse_animation_->StartThrobbing(std::numeric_limits<int>::max());
 }
@@ skipping 254 matching lines @@
   favicon_ = gfx::ImageSkia();
 }
 
 const char* Tab::GetClassName() const {
   return kViewClassName;
 }
 
 bool Tab::GetTooltipText(const gfx::Point& p, base::string16* tooltip) const {
   // Note: Anything that affects the tooltip text should be accounted for when
   // calling TooltipTextChanged() from Tab::DataChanged().
-  *tooltip = chrome::AssembleTabTooltipText(data_.title, data_.alert_state);
+  *tooltip = chrome::AssembleTabTooltipText(data_.title, data_.alert_state,
+                                            data_.network_state);
   return !tooltip->empty();
 }
 
 bool Tab::GetTooltipTextOrigin(const gfx::Point& p, gfx::Point* origin) const {
   origin->set_x(title_->x() + 10);
   origin->set_y(-4);
   return true;
 }
 
 bool Tab::OnMousePressed(const ui::MouseEvent& event) {
@@ skipping 128 matching lines @@
       break;
 
     default:
       break;
   }
   event->SetHandled();
 }
 
 void Tab::GetAccessibleNodeData(ui::AXNodeData* node_data) {
   node_data->role = ui::AX_ROLE_TAB;
-  node_data->SetName(data_.title);
+
+  node_data->SetName(GetAccessibleTabLabel(data_));
   node_data->AddStateFlag(ui::AX_STATE_MULTISELECTABLE);
   node_data->AddStateFlag(ui::AX_STATE_SELECTABLE);
   controller_->UpdateTabAccessibilityState(this, node_data);
   if (IsSelected())
     node_data->AddStateFlag(ui::AX_STATE_SELECTED);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // Tab, private
 
@@ skipping 64 matching lines @@
   // Draw a gray rectangle to represent the tab. This works for pinned tabs as
   // well as regular ones. The active tab has a brigher bar.
   SkColor color =
       IsActive() ? kImmersiveActiveTabColor : kImmersiveInactiveTabColor;
   gfx::Rect bar_rect = GetImmersiveBarRect();
   canvas->FillRect(bar_rect, SkColorSetA(color, alpha));
 
   // Paint network activity indicator.
   // TODO(jamescook): Replace this placeholder animation with a real one.
   // For now, let's go with a Cylon eye effect, but in blue.
-  if (data().network_state != TabRendererData::NETWORK_STATE_NONE) {
+  if (data().network_state != TabRendererData::NETWORK_STATE_NONE &&
+      data().network_state != TabRendererData::NETWORK_STATE_ERROR) {
     const SkColor kEyeColor = SkColorSetARGB(alpha, 71, 138, 217);
     int eye_width = bar_rect.width() / 3;
     int eye_offset = bar_rect.width() * immersive_loading_step_ /
         kImmersiveLoadingStepCount;
     if (eye_offset + eye_width < bar_rect.width()) {
       // Draw a single indicator strip because it fits inside |bar_rect|.
       gfx::Rect eye_rect(
           bar_rect.x() + eye_offset, 0, eye_width, kImmersiveBarHeight);
       canvas->FillRect(eye_rect, kEyeColor);
     } else {
@@ skipping 184 matching lines @@
 
 void Tab::PaintIcon(gfx::Canvas* canvas) {
   gfx::Rect bounds = favicon_bounds_;
   bounds.set_x(GetMirroredXForRect(bounds));
   bounds.Offset(0, favicon_hiding_offset_);
   bounds.Intersect(GetContentsBounds());
   if (bounds.IsEmpty())
     return;
 
   // Throbber will do its own painting.
-  if (data().network_state != TabRendererData::NETWORK_STATE_NONE)
+  if (data().network_state != TabRendererData::NETWORK_STATE_NONE &&
+      data().network_state != TabRendererData::NETWORK_STATE_ERROR) {
     return;
-
+  }
   // Ensure that |favicon_| is created.
   if (favicon_.isNull()) {
     ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
     favicon_ = should_display_crashed_favicon_
                    ? *rb->GetImageSkiaNamed(IDR_CRASH_SAD_FAVICON)
                    : data().favicon;
     // Themify the icon if it's a chrome:// page or if it's the sadtab favicon.
     // This ensures chrome:// pages are visible over the tab background. This is
     // similar to code in the bookmarks bar.
     if (!favicon_.isNull() &&
@@ skipping 29 matching lines @@
       immersive_loading_step_ =
           (immersive_loading_step_ + 1) % kImmersiveLoadingStepCount;
     } else {
       immersive_loading_step_ = 0;
     }
 
     SchedulePaintInRect(GetImmersiveBarRect());
     return;
   }
 
-  if (state == TabRendererData::NETWORK_STATE_NONE) {
+  if (state == TabRendererData::NETWORK_STATE_NONE ||
+      state == TabRendererData::NETWORK_STATE_ERROR) {
     throbber_->ResetStartTimes();
     throbber_->SetVisible(false);
     ScheduleIconPaint();
     return;
   }
 
   // Since the throbber can animate for a long time, paint to a separate layer
   // when possible to reduce repaint overhead.
   const bool paint_to_layer = controller_->CanPaintThrobberToLayer();
   if (paint_to_layer != !!throbber_->layer()) {
@@ skipping 121 matching lines @@
   SchedulePaintInRect(bounds);
 }
 
 gfx::Rect Tab::GetImmersiveBarRect() const {
   // The main bar is as wide as the normal tab's horizontal top line.
   gfx::Rect contents = GetContentsBounds();
   contents.set_y(0);
   contents.set_height(kImmersiveBarHeight);
   return contents;
 }