Issue 249733002: Use default save() flags in SkBlurDrawLooper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 249733002: Use default save() flags in SkBlurDrawLooper. (Closed)

Created:
6 years, 8 months ago by f(malita)

Modified:
6 years, 8 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Use default save() flags in SkBlurDrawLooper. SkBlurDrawLooper::BlurDrawLooperContext::next() is explicitely saving the matrix - but it doesn't rely on any clip changes persisting after restore(). Use the default flags instead (previous internal SaveFlags cleanup missed this user). R=robertphillips@google.com Committed: http://code.google.com/p/skia/source/detail?r=14335

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/effects/SkBlurDrawLooper.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/249733002/1

6 years, 8 months ago (2014-04-23 17:13:19 UTC) #4

Message was sent while issue was closed.

Change committed as 14335

Expand Messages | Collapse Messages