Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2497313002: android: Don't keep GSA alive if it supports account change broadcasts. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 75383a75843cf4a6292b01f945222a7227828f39..906c9cd63662c43bf6565f08b8acd53482d1ed2a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -76,7 +76,7 @@ import org.chromium.chrome.browser.download.DownloadManagerService;
import org.chromium.chrome.browser.download.DownloadUtils;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.gsa.ContextReporter;
-import org.chromium.chrome.browser.gsa.GSAServiceClient;
+import org.chromium.chrome.browser.gsa.GSAAccountChangeListener;
import org.chromium.chrome.browser.gsa.GSAState;
import org.chromium.chrome.browser.help.HelpAndFeedback;
import org.chromium.chrome.browser.infobar.InfoBarContainer;
@@ -183,7 +183,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
private TabContentManager mTabContentManager;
private UmaSessionStats mUmaSessionStats;
private ContextReporter mContextReporter;
- protected GSAServiceClient mGSAServiceClient;
private boolean mPartnerBrowserRefreshNeeded;
@@ -584,8 +583,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
ChromeActivitySessionTracker.getInstance().onStartWithNative();
if (GSAState.getInstance(this).isGsaAvailable()) {
- mGSAServiceClient = new GSAServiceClient(this);
- mGSAServiceClient.connect();
+ GSAAccountChangeListener.getInstance().connect();
createContextReporterIfNeeded();
} else {
ContextReporter.reportStatus(ContextReporter.STATUS_GSA_NOT_AVAILABLE);
@@ -687,9 +685,9 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
Tab tab = getActivityTab();
if (tab != null && !hasWindowFocus()) tab.onActivityHidden();
if (mAppMenuHandler != null) mAppMenuHandler.hideAppMenu();
- if (mGSAServiceClient != null) {
- mGSAServiceClient.disconnect();
- mGSAServiceClient = null;
+
+ if (GSAState.getInstance(this).isGsaAvailable()) {
+ GSAAccountChangeListener.getInstance().disconnect();
if (mSyncStateChangedListener != null) {
ProfileSyncService syncService = ProfileSyncService.get();
if (syncService != null) {

Powered by Google App Engine
This is Rietveld 408576698