Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: services/ui/ws/platform_display.h

Issue 2497303002: Fix ws::Display initialization order. (Closed)
Patch Set: Fix use after move in test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/frame_generator.cc ('k') | services/ui/ws/platform_display.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/platform_display.h
diff --git a/services/ui/ws/platform_display.h b/services/ui/ws/platform_display.h
index 33ad23ecec99670c01907c07cde32c3530953154..702e9f99c944117d2b0c643e8fa515c3baf4dc05 100644
--- a/services/ui/ws/platform_display.h
+++ b/services/ui/ws/platform_display.h
@@ -7,9 +7,7 @@
#include <stdint.h>
-#include <map>
#include <memory>
-#include <utility>
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
@@ -26,10 +24,6 @@
#include "ui/display/display.h"
#include "ui/platform_window/platform_window_delegate.h"
-namespace cc {
-class CopyOutputRequest;
-} // namespace cc
-
namespace gfx {
class Rect;
}
@@ -39,18 +33,13 @@ class GpuChannelHost;
}
namespace ui {
+
class CursorLoader;
class PlatformWindow;
struct TextInputState;
-} // namespace ui
-
-namespace ui {
-
-class FrameGenerator;
namespace ws {
-class EventDispatcher;
class PlatformDisplayFactory;
struct PlatformDisplayInitParams;
class ServerWindow;
@@ -60,7 +49,8 @@ class PlatformDisplay {
public:
virtual ~PlatformDisplay() {}
- static PlatformDisplay* Create(const PlatformDisplayInitParams& init_params);
+ static std::unique_ptr<PlatformDisplay> Create(
+ const PlatformDisplayInitParams& init_params);
virtual int64_t GetId() const = 0;
« no previous file with comments | « services/ui/ws/frame_generator.cc ('k') | services/ui/ws/platform_display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698