Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 2497293003: Remove static clues from spawn_uri_child_isolate.dart (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove static clues from spawn_uri_child_isolate.dart - the tests should be able to work without it. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/03bf746918d2238212bb9aaa9fdf304113043053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/isolate/spawn_uri_child_isolate.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-14 14:52:56 UTC) #2
Siggi Cherem (dart-lang)
lgtm - but do we need to remove this?
4 years, 1 month ago (2016-11-14 17:38:23 UTC) #3
Johnni Winther
On 2016/11/14 17:38:23, Siggi Cherem (dart-lang) wrote: > lgtm - but do we need to ...
4 years, 1 month ago (2016-11-15 12:03:07 UTC) #4
Johnni Winther
4 years, 1 month ago (2016-11-15 12:19:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03bf746918d2238212bb9aaa9fdf304113043053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698