Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2497273003: Make arm32 cpu detection recognize the DragonBoard as arm64. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make arm32 cpu detection recognize the DragonBoard as arm64. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/a01c63752244d4da45b6a66b1387dd97b4435ca0

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M runtime/vm/cpu_arm.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/cpuinfo.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/cpuinfo_android.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/cpuinfo_fuchsia.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/cpuinfo_linux.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/cpuinfo_macos.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/cpuinfo_win.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-14 23:35:54 UTC) #2
zra
lgtm https://codereview.chromium.org/2497273003/diff/20001/runtime/vm/cpu_arm.cc File runtime/vm/cpu_arm.cc (right): https://codereview.chromium.org/2497273003/diff/20001/runtime/vm/cpu_arm.cc#newcode171 runtime/vm/cpu_arm.cc:171: CpuInfo::FieldContains(kCpuInfoArchitecture, "8")) { Also check if this is ...
4 years, 1 month ago (2016-11-14 23:57:08 UTC) #3
rmacnak
https://codereview.chromium.org/2497273003/diff/20001/runtime/vm/cpu_arm.cc File runtime/vm/cpu_arm.cc (right): https://codereview.chromium.org/2497273003/diff/20001/runtime/vm/cpu_arm.cc#newcode171 runtime/vm/cpu_arm.cc:171: CpuInfo::FieldContains(kCpuInfoArchitecture, "8")) { On 2016/11/14 23:57:08, zra wrote: > ...
4 years, 1 month ago (2016-11-15 00:46:27 UTC) #4
rmacnak
4 years, 1 month ago (2016-11-15 00:55:30 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a01c63752244d4da45b6a66b1387dd97b4435ca0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698