Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(51)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/mjsunit/array-push14.js
Issue
2497243002
:
[stubs] Port builtin for Array.push fast-case from Crankshaft to TF (Closed)
Patch Set: Fix GC mole
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
src/arm/code-stubs-arm.cc
src/arm64/code-stubs-arm64.cc
src/builtins/builtins.h
src/builtins/builtins-array.cc
src/code-factory.h
src/code-factory.cc
src/code-stub-assembler.h
src/code-stub-assembler.cc
src/code-stubs.h
src/code-stubs-hydrogen.cc
src/ia32/code-stubs-ia32.cc
src/interface-descriptors.h
src/interface-descriptors.cc
src/mips/code-stubs-mips.cc
src/mips64/code-stubs-mips64.cc
src/runtime/runtime.h
src/runtime/runtime-array.cc
src/x64/code-stubs-x64.cc
test/cctest/test-code-stub-assembler.cc
test/mjsunit/array-push-hole-double.js
test/mjsunit/array-push11.js
test/mjsunit/array-push13.js
test/mjsunit/array-push14.js
View unified diff
|
Download patch
« no previous file with comments
|
« test/mjsunit/array-push13.js
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
function __f_17(__v_9) {
6
var __v_10 = 0;
7
var count = 100000;
8
while (count-- != 0) {
9
var l = __v_9.push(0.5);
10
if (++__v_10 >= 2) return __v_9;
11
__v_10 = {};
12
}
13
return __v_9;
14
}
15
16
let a = __f_17([2.2]);
17
assertEquals(a[0], 2.2);
18
assertEquals(a[10000], 0.5);
OLD
NEW
« no previous file with comments
|
« test/mjsunit/array-push13.js
('k') |
no next file »
|
no next file with comments »
Issue 2497243002: [stubs] Port builtin for Array.push fast-case from Crankshaft to TF (Closed)
Created 4 years, 1 month ago by danno
Modified 4 years ago
Reviewers: ishell, Jakob Kummerow
Base URL:
Comments: 55
This is Rietveld
408576698