Fixing problem where applications are not getting centered when created after maximize mode starts

Fixing problem where applications are not getting centered when created after maximize mode starts

BUG=365868
TEST=visual and unit test

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266161

[Mr4D (OOO till 08-26), 2014-04-23 17:10:29]

Please have a look!

[oshima, 2014-04-24 21:01:25]

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
File ash/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_state.cc:60: work_area_in_parent.y();
I think

work_area_in_parent.ClampToCenteredSize(bounds)

should work. (the opposite does not)

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_state.cc:158: if
(window_state->window()->IsVisible())
how this can be not visible (in non minimized mode)?

[Mr4D (OOO till 08-26), 2014-04-24 21:42:20]

Please have another look!

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
File ash/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_state.cc:60: work_area_in_parent.y();
I tried this yesterday. And it did not work. Apparently I must have done
something wrong. That said - the name of the function and the use is far from
obvious. But arguably it makes the code look simpler.

Done.

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_state.cc:158: if
(window_state->window()->IsVisible())
Multi user mode for example. Before the window gets shown for the first time, ..
. But maybe I am missing something?

[oshima, 2014-04-24 21:57:52]

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
File ash/wm/maximize_mode/maximize_mode_window_state.cc (right):

https://codereview.chromium.org/249723002/diff/1/ash/wm/maximize_mode/maximiz...
ash/wm/maximize_mode/maximize_mode_window_state.cc:158: if
(window_state->window()->IsVisible())
On 2014/04/24 21:42:20, Mr4D wrote:
> Multi user mode for example. Before the window gets shown for the first time,
..
> . But maybe I am missing something?

I see. I don't think we do this in normal mode, but this is probably better.
lgtm.

[Mr4D (OOO till 08-26), 2014-04-24 23:20:36]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-04-24 23:21:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/249723002/20001

[commit-bot: I haz the power, 2014-04-25 00:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 00:11:48]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Mr4D (OOO till 08-26), 2014-04-25 02:04:56]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-04-25 02:06:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/249723002/20001

[commit-bot: I haz the power, 2014-04-25 08:39:14]

Change committed as 266161