Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2497223003: Allow IP literals in Alt-Svc hostnames. (Closed)

Created:
4 years, 1 month ago by Bence
Modified:
4 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow IP literals in Alt-Svc hostnames. This CL lands server change 139064393 by bnc. BUG=488484, 664173 Committed: https://crrev.com/99fab9842b9ad3cee0f63008ae746f534dbac567 Cr-Commit-Position: refs/heads/master@{#431987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -11 lines) Patch
M net/spdy/spdy_alt_svc_wire_format.cc View 1 chunk +27 lines, -8 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 2 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 1 month ago (2016-11-14 15:38:54 UTC) #4
Ryan Hamilton
lgtm
4 years, 1 month ago (2016-11-14 20:43:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497223003/1
4 years, 1 month ago (2016-11-14 20:45:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 23:51:12 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:58:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99fab9842b9ad3cee0f63008ae746f534dbac567
Cr-Commit-Position: refs/heads/master@{#431987}

Powered by Google App Engine
This is Rietveld 408576698