Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2497223002: Introduce a new ResourceRequesterInfo type for NavigationPreload. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index c899c8e5ad6e353fd628984da32df27054c8e3ad..c074651cb42c469b58061bf9905ee12c50504dfb 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -398,20 +398,20 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
ResourceRequestInfoImpl* original_info =
ResourceRequestInfoImpl::ForRequest(original_request);
+ ResourceRequesterInfo* requester_info = original_info->requester_info();
if (IsBrowserSideNavigationEnabled()) {
- // TODO(horo): Support NavigationPreload with PlzNavigate.
- DCHECK(original_info->requester_info()->IsBrowserSideNavigation());
- NOTIMPLEMENTED();
- return;
+ DCHECK(requester_info->IsBrowserSideNavigation());
+ } else {
+ DCHECK(requester_info->IsRenderer());
+ if (!requester_info->filter())
+ return;
}
- DCHECK(original_info->requester_info()->IsRenderer());
- if (!original_info->requester_info()->filter())
- return;
DCHECK(!url_loader_factory_);
mojom::URLLoaderFactoryPtr factory;
- URLLoaderFactoryImpl::Create(original_info->requester_info(),
- mojo::GetProxy(&url_loader_factory_));
+ URLLoaderFactoryImpl::Create(
+ ResourceRequesterInfo::CreateForNavigationPreload(requester_info),
+ mojo::GetProxy(&url_loader_factory_));
preload_handle_ = mojom::FetchEventPreloadHandle::New();

Powered by Google App Engine
This is Rietveld 408576698