Chromium Code Reviews

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2497223002: Introduce a new ResourceRequesterInfo type for NavigationPreload. (Closed)
Patch Set: incorporated mmenke's comment Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index 23446d510478fb3105532f20dfaa3becab85d9fc..53e809c55f00565e42483ab6b82b81ae3b85c682 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -382,20 +382,20 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
ResourceRequestInfoImpl* original_info =
ResourceRequestInfoImpl::ForRequest(original_request);
+ ResourceRequesterInfo* requester_info = original_info->requester_info();
if (IsBrowserSideNavigationEnabled()) {
- // TODO(horo): Support NavigationPreload with PlzNavigate.
- DCHECK(original_info->requester_info()->IsBrowserSideNavigation());
- NOTIMPLEMENTED();
- return;
+ DCHECK(requester_info->IsBrowserSideNavigation());
+ } else {
+ DCHECK(requester_info->IsRenderer());
+ if (!requester_info->filter())
+ return;
}
- DCHECK(original_info->requester_info()->IsRenderer());
- if (!original_info->requester_info()->filter())
- return;
DCHECK(!url_loader_factory_);
mojom::URLLoaderFactoryPtr factory;
- URLLoaderFactoryImpl::Create(original_info->requester_info(),
- mojo::GetProxy(&url_loader_factory_));
+ URLLoaderFactoryImpl::Create(
+ ResourceRequesterInfo::CreateForNavigationPreload(requester_info),
+ mojo::GetProxy(&url_loader_factory_));
preload_handle_ = mojom::FetchEventPreloadHandle::New();

Powered by Google App Engine