Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.cc

Issue 2497223002: Introduce a new ResourceRequesterInfo type for NavigationPreload. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_fetch_dispatcher.cc
diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.cc b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
index 44ee6c60148e7270bde3df5c5d16d22b2f14f722..729658e27e160598d10c1d1110ea7de467280c1f 100644
--- a/content/browser/service_worker/service_worker_fetch_dispatcher.cc
+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.cc
@@ -380,20 +380,19 @@ void ServiceWorkerFetchDispatcher::MaybeStartNavigationPreload(
ResourceRequestInfoImpl* original_info =
ResourceRequestInfoImpl::ForRequest(original_request);
- if (IsBrowserSideNavigationEnabled()) {
- // TODO(horo): Support NavigationPreload with PlzNavigate.
- DCHECK(original_info->requester_info()->IsBrowserSideNavigation());
- NOTIMPLEMENTED();
- return;
- }
- DCHECK(original_info->requester_info()->IsRenderer());
- if (!original_info->requester_info()->filter())
+ ResourceRequesterInfo* requester_info = original_info->requester_info();
+ DCHECK((IsBrowserSideNavigationEnabled() &&
yhirano 2016/12/01 09:40:02 I would prefer an explicit if-statement. If (IsBr
horo 2016/12/01 10:37:35 Done.
+ requester_info->IsBrowserSideNavigation()) ||
+ (!IsBrowserSideNavigationEnabled() && requester_info->IsRenderer()));
+
+ if (requester_info->IsRenderer() && !requester_info->filter())
return;
DCHECK(!url_loader_factory_);
mojom::URLLoaderFactoryPtr factory;
- URLLoaderFactoryImpl::Create(original_info->requester_info(),
- mojo::GetProxy(&url_loader_factory_));
+ URLLoaderFactoryImpl::Create(
+ ResourceRequesterInfo::CreateForNavigationPreload(requester_info),
+ mojo::GetProxy(&url_loader_factory_));
preload_handle_ = mojom::FetchEventPreloadHandle::New();

Powered by Google App Engine
This is Rietveld 408576698