Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: src/compiler.cc

Issue 2497213002: [debugger] simplify compile for debugging. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.h ('k') | src/debug/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 9fbf795e4923cc8858adced3f84acdb7d3620427..164f23815a02c8859dc18fe200f71f506f6ac807 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1120,12 +1120,10 @@ bool Compiler::CompileOptimized(Handle<JSFunction> function,
return true;
}
-bool Compiler::CompileDebugCode(Handle<JSFunction> function) {
- return CompileDebugCode(handle(function->shared()));
-}
-
bool Compiler::CompileDebugCode(Handle<SharedFunctionInfo> shared) {
Isolate* isolate = shared->GetIsolate();
+ // Code that cannot be compiled lazily are internal and not debuggable.
+ DCHECK(shared->allows_lazy_compilation());
Michael Starzinger 2016/11/14 09:19:11 I don't fully understand why this became a pre-con
DCHECK(AllowCompilation::IsAllowed(isolate));
// Start a compilation.
« no previous file with comments | « src/compiler.h ('k') | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698