Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2497213002: [debugger] simplify compile for debugging. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debugger] simplify compile for debugging. R=mstarzinger@chromium.org Committed: https://crrev.com/b62e2284b1d42993ca041214d2c378c245b32668 Cr-Commit-Position: refs/heads/master@{#40954}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -44 lines) Patch
M src/compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M src/debug/debug.cc View 1 3 chunks +7 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yang
4 years, 1 month ago (2016-11-14 08:49:07 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/2497213002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/2497213002/diff/1/src/compiler.cc#newcode1126 src/compiler.cc:1126: DCHECK(shared->allows_lazy_compilation()); I don't fully understand why this became ...
4 years, 1 month ago (2016-11-14 09:19:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497213002/20001
4 years, 1 month ago (2016-11-14 09:33:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 09:58:46 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:32:03 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b62e2284b1d42993ca041214d2c378c245b32668
Cr-Commit-Position: refs/heads/master@{#40954}

Powered by Google App Engine
This is Rietveld 408576698