Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: mojo/edk/embedder/embedder_unittest.cc

Issue 2497203002: Disable two tests in mojo_system_unittests that are suspected to be timing out (Closed)
Patch Set: fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/edk/system/multiprocess_message_pipe_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/embedder/embedder_unittest.cc
diff --git a/mojo/edk/embedder/embedder_unittest.cc b/mojo/edk/embedder/embedder_unittest.cc
index 4521f8037ed2d44c3c1c67c5b96ea828b1fb5988..f371f2a33010d7b712017a679f8884a28af86f00 100644
--- a/mojo/edk/embedder/embedder_unittest.cc
+++ b/mojo/edk/embedder/embedder_unittest.cc
@@ -224,7 +224,15 @@ TEST_F(EmbedderTest, PipeSetup_LaunchDeath) {
nullptr));
}
-TEST_F(EmbedderTest, PipeSetup_LaunchFailure) {
+#if defined(OS_ANDROID)
+// This test is suspected to be flaky on android https://crbug.com/663998.
+#define MAYBE_PipeSetup_LaunchFailure \
+ DISABLED_PipeSetup_LaunchFailure
+#else
+#define MAYBE_PipeSetup_LaunchFailure \
+ PipeSetup_LaunchFailure
+#endif
+TEST_F(EmbedderTest, MAYBE_PipeSetup_LaunchFailure) {
PlatformChannelPair pair;
std::string child_token = GenerateRandomToken();
« no previous file with comments | « no previous file | mojo/edk/system/multiprocess_message_pipe_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698