Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2497203002: Disable two tests in mojo_system_unittests that are suspected to be timing out (Closed)

Created:
4 years, 1 month ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable two tests in mojo_system_unittests that are suspected to be timing out BUG=663998 TBR=pdr@chromium.org, timloh@chromium.org Committed: https://crrev.com/aae520affa1d2c4397bf4d4758a9ff48d5a0cc88 Cr-Commit-Position: refs/heads/master@{#431847}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M mojo/edk/embedder/embedder_unittest.cc View 1 chunk +9 lines, -1 line 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497203002/20001
4 years, 1 month ago (2016-11-14 09:23:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 09:27:16 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/aae520affa1d2c4397bf4d4758a9ff48d5a0cc88 Cr-Commit-Position: refs/heads/master@{#431847}
4 years, 1 month ago (2016-11-14 09:28:54 UTC) #16
hiroshige
4 years, 1 month ago (2016-11-15 05:37:55 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2504533002/ by hiroshige@chromium.org.

The reason for reverting is: Issue 663998 still persists after this CL..

Powered by Google App Engine
This is Rietveld 408576698