Chromium Code Reviews
DescriptionReland of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2495613002/ )
Reason for revert:
The issue was resolved. Try to reland without any changes.
Original issue's description:
> Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2482793002/ )
>
> Reason for revert:
>
> I'm reverting this because I think
>
> imported/wpt/html/browsers/history/the-location-interface/reload_post_1.html
>
> started failing with the switch on windows, see
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8056
>
> and I'm the sheriff today.
>
> However, I'm also concerned that I think you missed my comments in #10. I don't think a 30% cycle time regression is okay,
> at least not without an explanation and a plan for addressing it.
>
> Original issue's description:
> > wptserve: Enable WPTServe by default.
> >
> > Feel free to revert this if you see stability issues of imported/wpt tests in
> > webkit_tests step.
> >
> > BUG=618366
> >
> > Committed: https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21
> > Cr-Commit-Position: refs/heads/master@{#431186}
>
> TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=618366
>
> Committed: https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4
> Cr-Commit-Position: refs/heads/master@{#431285}
TBR=jsbell@chromium.org,qyearsley@chromium.org,dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=618366
Committed: https://crrev.com/340ad8ad4eceb6603867b1fc3f9b3b295d76d79d
Cr-Commit-Position: refs/heads/master@{#431820}
Patch Set 1 #
Messages
Total messages: 13 (6 generated)
|
|||||||||||||||||||