Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2497193002: Reland of wptserve: Enable WPTServe by default. (Closed)

Created:
4 years, 1 month ago by tkent
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, Rick Byers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2495613002/ ) Reason for revert: The issue was resolved. Try to reland without any changes. Original issue's description: > Revert of wptserve: Enable WPTServe by default. (patchset #1 id:1 of https://codereview.chromium.org/2482793002/ ) > > Reason for revert: > > I'm reverting this because I think > > imported/wpt/html/browsers/history/the-location-interface/reload_post_1.html > > started failing with the switch on windows, see > > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/8056 > > and I'm the sheriff today. > > However, I'm also concerned that I think you missed my comments in #10. I don't think a 30% cycle time regression is okay, > at least not without an explanation and a plan for addressing it. > > Original issue's description: > > wptserve: Enable WPTServe by default. > > > > Feel free to revert this if you see stability issues of imported/wpt tests in > > webkit_tests step. > > > > BUG=618366 > > > > Committed: https://crrev.com/311d6ccdab758c38b0394a06d054a4db15a5fa21 > > Cr-Commit-Position: refs/heads/master@{#431186} > > TBR=qyearsley@chromium.org,jsbell@chromium.org,tkent@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=618366 > > Committed: https://crrev.com/05bb9406c894324faea17e0b4cc78bcfffafcff4 > Cr-Commit-Position: refs/heads/master@{#431285} TBR=jsbell@chromium.org,qyearsley@chromium.org,dpranke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618366 Committed: https://crrev.com/340ad8ad4eceb6603867b1fc3f9b3b295d76d79d Cr-Commit-Position: refs/heads/master@{#431820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
tkent
Created Reland of wptserve: Enable WPTServe by default.
4 years, 1 month ago (2016-11-14 02:14:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2497193002/1
4 years, 1 month ago (2016-11-14 03:13:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-14 03:18:11 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/340ad8ad4eceb6603867b1fc3f9b3b295d76d79d Cr-Commit-Position: refs/heads/master@{#431820}
4 years, 1 month ago (2016-11-14 03:20:15 UTC) #10
qyearsley
lgtm
4 years, 1 month ago (2016-11-14 17:33:02 UTC) #11
Dirk Pranke
lgtm
4 years, 1 month ago (2016-11-14 17:33:08 UTC) #12
Dirk Pranke
4 years ago (2016-11-30 03:19:19 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2537413002/ by dpranke@chromium.org.

The reason for reverting is: I suspect that the startup/shutdown logic in
wptserve is not right, and we're seeing intermittent failures where we're
hanging trying to start wptserve. 

See crbug.com/669194 and
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/build...
for an example.

I'm speculatively reverting this for now, to see if things become happier..

Powered by Google App Engine
This is Rietveld 408576698