Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2497153002:
Clean up pylint warnings in filesystem_mock.py. (Closed)
DescriptionClean up pylint warnings in filesystem_mock.py.
Warnings fixed:
- 1 unused import
- some variable names very short
- some variable/argument names conflict with builtins
BUG=643937
Committed: https://crrev.com/6180682439e536c07e8b4a69d9347aac6698929f
Cr-Commit-Position: refs/heads/master@{#432317}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Use lambda #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Clean up pylint warnings in filesystem_mock.py. BUG=643937 ========== to ========== Clean up pylint warnings in filesystem_mock.py. Warnings fixed: - 1 unused import - some variable names very short - some variable/argument names conflict with builtins BUG=643937 ==========
qyearsley@chromium.org changed reviewers: + jeffcarp@chromium.org
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/14 at 21:18:52, qyearsley wrote: > lgtm with one question
On 2016/11/15 at 03:29:34, jeffcarp wrote: > On 2016/11/14 at 21:18:52, qyearsley wrote: > > > > lgtm with one question Note, you have to "publish" before any of your comments in the code are visible :-P
Oops I goofed... here is the question https://codereview.chromium.org/2497153002/diff/1/third_party/WebKit/Tools/Sc... File third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right): https://codereview.chromium.org/2497153002/diff/1/third_party/WebKit/Tools/Sc... third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py:131: return True Would turning this into a lambda get rid of the lint error? I seem to remember that being the case for the code we worked on last week...
On 2016/11/15 at 19:10:01, jeffcarp wrote: > Oops I goofed... here is the question > > https://codereview.chromium.org/2497153002/diff/1/third_party/WebKit/Tools/Sc... > File third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right): > > https://codereview.chromium.org/2497153002/diff/1/third_party/WebKit/Tools/Sc... > third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py:131: return True > Would turning this into a lambda get rid of the lint error? I seem to remember that being the case for the code we worked on last week... Yeah, that worked, and it also made the code shorter :-D
The CQ bit was checked by qyearsley@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jeffcarp@chromium.org Link to the patchset: https://codereview.chromium.org/2497153002/#ps20001 (title: "Use lambda")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Clean up pylint warnings in filesystem_mock.py. Warnings fixed: - 1 unused import - some variable names very short - some variable/argument names conflict with builtins BUG=643937 ========== to ========== Clean up pylint warnings in filesystem_mock.py. Warnings fixed: - 1 unused import - some variable names very short - some variable/argument names conflict with builtins BUG=643937 Committed: https://crrev.com/6180682439e536c07e8b4a69d9347aac6698929f Cr-Commit-Position: refs/heads/master@{#432317} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6180682439e536c07e8b4a69d9347aac6698929f Cr-Commit-Position: refs/heads/master@{#432317} |
