Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 249713006: Mojo: Fix crash on MojoShell on Android (Closed)

Created:
6 years, 8 months ago by Hajime Morrita
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Fix crash on MojoShell on Android MojoShell crashed when it goes backgound then comes to front again. It did hit an assertion in InitApplicationContext() that is expected to be called oly once for each process. This change ensures it to be called once at most. TEST=none BUG=none R=abarth,beng Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266147

Patch Set 1 #

Patch Set 2 : Updated to ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoMain.java View 2 chunks +15 lines, -1 line 0 comments Download
M mojo/shell/android/apk/src/org/chromium/mojo_shell_apk/MojoShellActivity.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Hajime Morrita
PTAL? A trivial crash fix.
6 years, 8 months ago (2014-04-23 21:47:54 UTC) #1
abarth-chromium
lgtm
6 years, 8 months ago (2014-04-23 21:52:09 UTC) #2
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-23 21:52:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/249713006/1
6 years, 8 months ago (2014-04-23 21:53:00 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 22:42:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-23 22:42:04 UTC) #6
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-23 22:45:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/249713006/1
6 years, 8 months ago (2014-04-23 22:46:43 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-23 23:34:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-23 23:34:35 UTC) #10
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-25 00:10:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/249713006/20001
6 years, 8 months ago (2014-04-25 00:11:57 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 07:34:04 UTC) #13
Message was sent while issue was closed.
Change committed as 266147

Powered by Google App Engine
This is Rietveld 408576698